[coreboot-gerrit] New patch to review for coreboot: ec/lenovo/h8: Replace `<<` by older compatible syntax

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Tue Feb 28 20:40:18 CET 2017


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18520

-gerrit

commit ed462634b2014473e2cd0b25e00cf97f763e5d58
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Tue Feb 28 20:23:37 2017 +0100

    ec/lenovo/h8: Replace `<<` by older compatible syntax
    
    ```
    Intel ACPI Component Architecture
    ASL Optimizing Compiler version 20140926-32 [Oct  1 2014]
    Copyright (c) 2000 - 2014 Intel Corporation
    
    Compiler aborting due to parser-detected syntax error(s)
    dsdt.aml   1698:    Return (TBSW << 3)
    Error    6126 -                 ^ Invalid character (0x3C), expecting ASL keyword or name
    
                                            Store (DHKN, EMSK)
    dsdt.aml   1698:    Return (TBSW << 3)
    Error    6126 -                  ^ Invalid character (0x3C), expecting ASL keyword or name
    
    dsdt.aml   1698:    Return (TBSW << 3)
    Error    6126 -                    ^ syntax error, unexpected PARSEOP_INTEGER, expecting ')'
    
    ASL Input:     dsdt.aml - 2405 lines, 42862 bytes, 1000 keywords
    
    Compilation complete. 3 Errors, 0 Warnings, 0 Remarks, 0 Optimizations
    ```
    
    Change-Id: Id7e309c31612387da3920cf7d846b358ac2bdc71
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/ec/lenovo/h8/acpi/ec.asl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ec/lenovo/h8/acpi/ec.asl b/src/ec/lenovo/h8/acpi/ec.asl
index b8350ad..ed62afe 100644
--- a/src/ec/lenovo/h8/acpi/ec.asl
+++ b/src/ec/lenovo/h8/acpi/ec.asl
@@ -363,7 +363,7 @@ Device(EC)
 		/* Report tablet mode switch state */
 		Method (MHKG, 0, NotSerialized)
 		{
-			Return (TBSW << 3)
+			Return (ShiftLeft(TBSW, 3))
 		}
 		/* Mute audio */
 		Method (SSMS, 1, NotSerialized)



More information about the coreboot-gerrit mailing list