[coreboot-gerrit] New patch to review for coreboot: mb/apple/macbook21: Remove PCI reset code from romstage
Mono Moosbart (mono-for-coreboot@donderklumpen.de)
gerrit at coreboot.org
Sun Feb 26 13:44:28 CET 2017
Mono Moosbart (mono-for-coreboot at donderklumpen.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18502
-gerrit
commit 7e2330a08567f33b7109033f1dbcc0203a1ed1ef
Author: Mono <mono-for-coreboot at donderklumpen.de>
Date: Sun Feb 26 13:35:17 2017 +0100
mb/apple/macbook21: Remove PCI reset code from romstage
Follow commit 7676730 (mb/lenovo/x60: Remove PCI reset code from
romstage). The PCI reset was copied from code specific for Roda
RK886EX and Kontron 986LCD-M. It is not needed on the MacBook.
Change-Id: I22dac962e8079732591f9bc134c1433f5c29ff4e
Signed-off-by: Axel Holewa <mono-for-coreboot at donderklumpen.de>
---
src/mainboard/apple/macbook21/romstage.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/src/mainboard/apple/macbook21/romstage.c b/src/mainboard/apple/macbook21/romstage.c
index 962ad41..92dfe74 100644
--- a/src/mainboard/apple/macbook21/romstage.c
+++ b/src/mainboard/apple/macbook21/romstage.c
@@ -253,11 +253,6 @@ void mainboard_romstage_entry(unsigned long bist)
if (bist == 0)
enable_lapic();
- /* Force PCIRST# */
- pci_write_config16(PCI_DEV(0, 0x1e, 0), BCTRL, SBR);
- udelay(200 * 1000);
- pci_write_config16(PCI_DEV(0, 0x1e, 0), BCTRL, 0);
-
ich7_enable_lpc();
/* Set up the console */
More information about the coreboot-gerrit
mailing list