[coreboot-gerrit] New patch to review for coreboot: nb/amd/amdmct: Remove unused table

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Fri Feb 24 17:27:58 CET 2017


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18486

-gerrit

commit f47ca0f2e309592e2ad4777f8be56fbdb5cf91de
Author: Martin Roth <martinroth at google.com>
Date:   Fri Feb 24 09:27:46 2017 -0700

    nb/amd/amdmct: Remove unused table
    
    This unused table causes a warning in the updated toolchain.
    
    Change-Id: I71816b44b4342d7cdb061bce84b2b49ecb9a1312
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/northbridge/amd/amdmct/mct/mctardk4.c | 20 +-------------------
 1 file changed, 1 insertion(+), 19 deletions(-)

diff --git a/src/northbridge/amd/amdmct/mct/mctardk4.c b/src/northbridge/amd/amdmct/mct/mctardk4.c
index b35f7ba..3e9d1f4 100644
--- a/src/northbridge/amd/amdmct/mct/mctardk4.c
+++ b/src/northbridge/amd/amdmct/mct/mctardk4.c
@@ -77,24 +77,6 @@ static const u8 Table_ATC_ODC_D_Bx[] = {
 	0xFF
 };
 
-static const u8 Table_ATC_ODC_D_Ax[] = {
-	1, 0xFF, 0x00, 0x2F, 0x2F, 0x0, 0x22, 0x13, 0x11, 0x0,
-	2,   12, 0x00, 0x2F, 0x2F, 0x0, 0x22, 0x13, 0x11, 0x0,
-	2,   16, 0x00, 0x2F, 0x00, 0x0, 0x22, 0x13, 0x11, 0x0,
-	2,   20, 0x00, 0x2F, 0x38, 0x0, 0x22, 0x13, 0x11, 0x0,
-	2,   24, 0x00, 0x2F, 0x37, 0x0, 0x22, 0x13, 0x11, 0x0,
-	2,   32, 0x00, 0x2F, 0x34, 0x0, 0x22, 0x13, 0x11, 0x0,
-	3,   12, 0x20, 0x22, 0x20, 0x0, 0x22, 0x13, 0x11, 0x0,
-	3,   16, 0x20, 0x22, 0x30, 0x0, 0x22, 0x13, 0x11, 0x0,
-	3,   20, 0x20, 0x22, 0x2C, 0x0, 0x22, 0x13, 0x11, 0x0,
-	3,   24, 0x20, 0x22, 0x2A, 0x0, 0x22, 0x13, 0x11, 0x0,
-	3,   32, 0x20, 0x22, 0x2B, 0x0, 0x22, 0x13, 0x11, 0x0,
-	4, 0xFF, 0x20, 0x25, 0x20, 0x0, 0x22, 0x33, 0x11, 0x0,
-	5, 0xFF, 0x20, 0x20, 0x2F, 0x0, 0x22, 0x32, 0x11, 0x0,
-	0xFF
-};
-
-
 static void Get_ChannelPS_Cfg0_D(u8 MAAdimms, u8 Speed, u8 MAAload,
 				u8 DATAAload, u32 *AddrTmgCTL, u32 *ODC_CTL,
 				u8 *CMDmode)
@@ -105,7 +87,7 @@ static void Get_ChannelPS_Cfg0_D(u8 MAAdimms, u8 Speed, u8 MAAload,
 	*ODC_CTL = 0;
 	*CMDmode = 1;
 
-	// FIXME: add Ax support
+	// FIXME: add Ax support (table is in git history)
 	if (MAAdimms == 0) {
 		*ODC_CTL = 0x00111222;
 		if (Speed == 3)



More information about the coreboot-gerrit mailing list