[coreboot-gerrit] Patch set updated for coreboot: soc/intel/apollolake: Extract DIMM Information from FSP MEM INFO HOB
Barnali Sarkar (barnali.sarkar@intel.com)
gerrit at coreboot.org
Thu Feb 23 12:31:32 CET 2017
Barnali Sarkar (barnali.sarkar at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18451
-gerrit
commit 6f2c0b2425da822469d5ffa681fb3398f23650ed
Author: Barnali Sarkar <barnali.sarkar at intel.com>
Date: Tue Feb 21 17:48:53 2017 +0530
soc/intel/apollolake: Extract DIMM Information from FSP MEM INFO HOB
Extract SMBIOS memory information from FSP SMBIOS_MEM_INFO_HOB
and save it in CBMEM.
BUG=chrome-os-partner:61729
BRANCH=none
TEST=Build and boot Reef to verify the type 17 DIMM info coming in
SMBIOS table from Kernel command "dmidecode".
Change-Id: I33c3a0bebf33c53beadd745bc3d991e1e51050b7
Signed-off-by: Barnali Sarkar <barnali.sarkar at intel.com>
---
src/soc/intel/apollolake/meminit.c | 39 +++++++++-----------------------------
1 file changed, 9 insertions(+), 30 deletions(-)
diff --git a/src/soc/intel/apollolake/meminit.c b/src/soc/intel/apollolake/meminit.c
index 0f553ee..a4cdf40 100644
--- a/src/soc/intel/apollolake/meminit.c
+++ b/src/soc/intel/apollolake/meminit.c
@@ -16,7 +16,7 @@
#include <console/console.h>
#include <fsp/util.h>
#include <memory_info.h>
-#include <smbios.h>
+#include <soc/intel/common/smbios.h>
#include <soc/meminit.h>
#include <stddef.h> /* required for FspmUpd.h */
#include <fsp/soc_binding.h>
@@ -304,35 +304,14 @@ void save_lpddr4_dimm_info(const struct lpddr4_cfg *lp4cfg, size_t mem_sku)
continue;
/* Populate the DIMM information */
- dest_dimm->dimm_size = src_dimm->SizeInMb;
- dest_dimm->ddr_type = memory_info_hob->MemoryType;
- dest_dimm->ddr_frequency =
- memory_info_hob->MemoryFrequencyInMHz;
- dest_dimm->channel_num = channel_info->ChannelId;
- dest_dimm->dimm_num = src_dimm->DimmId;
- strncpy((char *)dest_dimm->module_part_number,
- lp4cfg->skus[mem_sku].part_num,
- sizeof(dest_dimm->module_part_number));
-
- switch (memory_info_hob->DataWidth) {
- case 8:
- dest_dimm->bus_width = MEMORY_BUS_WIDTH_8;
- break;
- case 16:
- dest_dimm->bus_width = MEMORY_BUS_WIDTH_16;
- break;
- case 32:
- dest_dimm->bus_width = MEMORY_BUS_WIDTH_32;
- break;
- case 64:
- dest_dimm->bus_width = MEMORY_BUS_WIDTH_64;
- break;
- case 128:
- dest_dimm->bus_width = MEMORY_BUS_WIDTH_128;
- break;
- default:
- printk(BIOS_ERR, "Incorrect DIMM Data Width");
- }
+ dimm_info_fill(dest_dimm,
+ src_dimm->SizeInMb,
+ memory_info_hob->MemoryType,
+ memory_info_hob->MemoryFrequencyInMHz,
+ channel_info->ChannelId,
+ src_dimm->DimmId,
+ (const char *)lp4cfg->skus[mem_sku].part_num,
+ memory_info_hob->DataWidth);
index++;
}
}
More information about the coreboot-gerrit
mailing list