[coreboot-gerrit] Patch set updated for coreboot: ec/lenovo/h8: Pulse the power LED during S3, if supported

[Nicola Corna (nicola@corna.info)]

Nicola Corna (nicola at corna.info) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18325

-gerrit

commit c8775e12b61f25e69fcaf61f707be82160bbb55f
Author: Nicola Corna <nicola at corna.info>
Date:   Fri Feb 10 13:05:04 2017 +0100

    ec/lenovo/h8: Pulse the power LED during S3, if supported
    
    On the models that support it (like the X220) the LED pulses, on
    the others (like the X201) the LED powers off.
    
    Change-Id: I2ac7dbc30609179e4ca5fc0a7b06763431fe3344
    Signed-off-by: Nicola Corna <nicola at corna.info>
---
 src/ec/lenovo/h8/acpi/systemstatus.asl | 4 ++--
 src/ec/lenovo/h8/h8.h                  | 9 +++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src/ec/lenovo/h8/acpi/systemstatus.asl b/src/ec/lenovo/h8/acpi/systemstatus.asl
index e115842..378ce01 100644
--- a/src/ec/lenovo/h8/acpi/systemstatus.asl
+++ b/src/ec/lenovo/h8/acpi/systemstatus.asl
@@ -49,8 +49,8 @@ Scope (\_SI)
 		If (LEqual (Arg0, 3)) {
 			/* sleep state */
 
-			/* power TLED off */
-			\_SB.PCI0.LPCB.EC.TLED(0x00)
+			/* power TLED pulsing */
+			\_SB.PCI0.LPCB.EC.TLED(0xa0)
 			/* suspend TLED on */
 			\_SB.PCI0.LPCB.EC.TLED(0x87)
 		}
diff --git a/src/ec/lenovo/h8/h8.h b/src/ec/lenovo/h8/h8.h
index 290db91..c721d38 100644
--- a/src/ec/lenovo/h8/h8.h
+++ b/src/ec/lenovo/h8/h8.h
@@ -63,12 +63,9 @@ void h8_mainboard_init_dock (void);
 #define H8_LED_CONTROL		0x0c
 #define H8_LED_CONTROL_OFF		0x00
 #define H8_LED_CONTROL_ON		0x80
+#define H8_LED_CONTROL_PULSE		0xa0	/* Some models, power LED only*/
 #define H8_LED_CONTROL_BLINK		0xc0
 
-#define H8_USB_ALWAYS_ON		0x0d
-#define H8_USB_ALWAYS_ON_ENABLE		0x01
-#define H8_USB_ALWAYS_ON_AC_ONLY	0x0c
-
 #define H8_LED_CONTROL_POWER_LED	0x00
 #define H8_LED_CONTROL_BAT0_LED	0x01
 #define H8_LED_CONTROL_BAT1_LED	0x02
@@ -77,6 +74,10 @@ void h8_mainboard_init_dock (void);
 #define H8_LED_CONTROL_DOCK_LED1	0x08
 #define H8_LED_CONTROL_DOCK_LED2	0x09
 
+#define H8_USB_ALWAYS_ON		0x0d
+#define H8_USB_ALWAYS_ON_ENABLE		0x01
+#define H8_USB_ALWAYS_ON_AC_ONLY	0x0c
+
 #define H8_FAN_CONTROL			0x2f
 #define H8_FAN_CONTROL_AUTO		0x80