[coreboot-gerrit] Patch set updated for coreboot: commonlib/fsp.h: include sys/types.h for ssize_t

Jonathan Neuschäfer (j.neuschaefer@gmx.net) gerrit at coreboot.org
Tue Feb 21 13:32:59 CET 2017


Jonathan Neuschäfer (j.neuschaefer at gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18417

-gerrit

commit 306ba317b640d440df72cea6c888dc386a4df46e
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Tue Feb 21 13:10:05 2017 +0100

    commonlib/fsp.h: include sys/types.h for ssize_t
    
    This file reportedly didn't compile on SUSE Linux with gcc 4.3.4:
    
    [...]
    >     HOSTCC     cbfstool/fsp_relocate.o
    > In file included from /home/aladyshev/coreboot_2017/src/commonlib/fsp_relocate.c:18:
    > /home/aladyshev/coreboot_2017/src/commonlib/include/commonlib/fsp.h:26: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'fsp_component_relocate'
    [...]
    
    According to POSIX-2008[1], sys/types.h defines ssize_t, so include it.
    This should not break coreboot code (as supposed to utils code), as we
    have a sys/types.h in src/include.
    
    Don't include stdint.h as it doesn't define any of the types used in fsp.h.
    
    [1]: http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_types.h.html
    
    Change-Id: Id3694dc76c41d800ba09183e4b039b0719ac3d93
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
 src/commonlib/include/commonlib/fsp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/commonlib/include/commonlib/fsp.h b/src/commonlib/include/commonlib/fsp.h
index 84e2c98..ec78caf 100644
--- a/src/commonlib/include/commonlib/fsp.h
+++ b/src/commonlib/include/commonlib/fsp.h
@@ -17,7 +17,7 @@
 #define _COMMONLIB_FSP_H_
 
 #include <stddef.h>
-#include <stdint.h>
+#include <sys/types.h>
 
 /*
  * Relocate FSP held within buffer defined by size to new_addr. Returns < 0



More information about the coreboot-gerrit mailing list