[coreboot-gerrit] Patch merged into coreboot/master: ec/lenovo: Add guards to fix build errors without SMBIOS

gerrit at coreboot.org gerrit at coreboot.org
Mon Feb 20 04:46:52 CET 2017


the following patch was just integrated into master:
commit 2a4a452abc376ad1dd3491c877422c72a7668391
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Thu Dec 8 00:03:38 2016 +0100

    ec/lenovo: Add guards to fix build errors without SMBIOS
    
    Not selecting the Kconfig option `GENERATE_SMBIOS_TABLES` the build
    fails with the error below.
    
    ```
        CC         ramstage/ec/lenovo/h8/h8.o
    src/ec/lenovo/h8/h8.c:201:2: error: unknown field 'get_smbios_strings' specified in initializer
      .get_smbios_strings = h8_smbios_strings,
      ^
    src/ec/lenovo/h8/h8.c:201:2: error: initialization from incompatible pointer type [-Werror]
    src/ec/lenovo/h8/h8.c:201:2: error: (near initialization for 'h8_dev_ops.read_resources') [-Werror]
    cc1: all warnings being treated as errors
    ```
    
    So add the appropriate preprocessor guards to fix the build error.
    
    Change-Id: I3baed452d422539a805c628a8c4a6a8c2a809317
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: https://review.coreboot.org/17770
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Rudolph <siro at das-labor.org>


See https://review.coreboot.org/17770 for details.

-gerrit



More information about the coreboot-gerrit mailing list