[coreboot-gerrit] Patch merged into coreboot/master: riscv: Suppress invalid coverity errors

gerrit at coreboot.org gerrit at coreboot.org
Mon Feb 20 04:40:04 CET 2017


the following patch was just integrated into master:
commit f797a1ac6a72a571ba76bff8b7c451cc090778a9
Author: Martin Roth <martinroth at google.com>
Date:   Thu Jan 26 15:37:10 2017 -0700

    riscv: Suppress invalid coverity errors
    
    Coverity is detecting 'sp' as a variable which has not been initialized.
    This is obviously not correct, so this patch *TRIES* to mark it as false
    
    I'm not positive that this will work because the annotation needs to go
    on the line above the error, but this error is inside of a # define.
    
    Does the whole #define count as one line?  Can it go on the line
    above the #define in the .h file?  Does it have to precede every line
    where the #define is used?  The documentation doesn't make this clear.
    
    Should suppress coverity issues: 1368525 & 1368527
    uninit_use: Using uninitialized value sp.
    
    Change-Id: Ibae5e206c4ff47991ea8a11b6b59972b24b71796
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/18247
    Tested-by: build bot (Jenkins)
    Reviewed-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>


See https://review.coreboot.org/18247 for details.

-gerrit



More information about the coreboot-gerrit mailing list