[coreboot-gerrit] Patch set updated for coreboot: intel/minnow3: Configure memory properly

Brenton Dong (brenton.m.dong@intel.com) gerrit at coreboot.org
Fri Feb 17 19:00:48 CET 2017


Brenton Dong (brenton.m.dong at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18374

-gerrit

commit 73b9403c5d427c8605749bd482346c7a41535762
Author: Brenton Dong <brenton.m.dong at intel.com>
Date:   Wed Feb 15 11:50:02 2017 -0700

    intel/minnow3: Configure memory properly
    
    Set the proper memory configuration for the MinnowBoard 3.  The current
    values are copied from intel/leafhill.  Set the proper values for
    MinnowBoard 3.
    
    Change-Id: Ie37842f5ce2cabaa892f42ee945c91fe3ace527a
    Signed-off-by: Brenton Dong <brenton.m.dong at intel.com>
---
 src/mainboard/intel/minnow3/romstage.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/mainboard/intel/minnow3/romstage.c b/src/mainboard/intel/minnow3/romstage.c
index 5c784ba..04cdad4 100644
--- a/src/mainboard/intel/minnow3/romstage.c
+++ b/src/mainboard/intel/minnow3/romstage.c
@@ -61,7 +61,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
 	memupd->FspmConfig.InterleavedMode = 0x2;
 	memupd->FspmConfig.ChannelsSlicesEnable = 0x0;
 	memupd->FspmConfig.MinRefRate2xEnable = 0x0;
-	memupd->FspmConfig.DualRankSupportEnable = 0x1;
+	memupd->FspmConfig.DualRankSupportEnable = 0x0;
 	memupd->FspmConfig.RmtMode = 0x0;
 	memupd->FspmConfig.MemorySizeLimit = 0x1800;
 	memupd->FspmConfig.LowMemoryMaxValue = 0x0;
@@ -69,7 +69,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
 	memupd->FspmConfig.HighMemoryMaxValue = 0x0;
 	memupd->FspmConfig.DIMM0SPDAddress = 0x0;
 	memupd->FspmConfig.DIMM1SPDAddress = 0x0;
-	memupd->FspmConfig.Ch0_RankEnable = 0x3;
+	memupd->FspmConfig.Ch0_RankEnable = 0x1;
 	memupd->FspmConfig.Ch0_DeviceWidth = 0x1;
 	memupd->FspmConfig.Ch0_DramDensity = 0x2;
 	memupd->FspmConfig.Ch0_Option = 0x3;
@@ -77,7 +77,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
 	memupd->FspmConfig.Ch0_TristateClk1 = 0x0;
 	memupd->FspmConfig.Ch0_Mode2N = 0x0;
 	memupd->FspmConfig.Ch0_OdtLevels = 0x0;
-	memupd->FspmConfig.Ch1_RankEnable = 0x3;
+	memupd->FspmConfig.Ch1_RankEnable = 0x1;
 	memupd->FspmConfig.Ch1_DeviceWidth = 0x1;
 	memupd->FspmConfig.Ch1_DramDensity = 0x2;
 	memupd->FspmConfig.Ch1_Option = 0x3;
@@ -85,7 +85,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
 	memupd->FspmConfig.Ch1_TristateClk1 = 0x0;
 	memupd->FspmConfig.Ch1_Mode2N = 0x0;
 	memupd->FspmConfig.Ch1_OdtLevels = 0x0;
-	memupd->FspmConfig.Ch2_RankEnable = 0x3;
+	memupd->FspmConfig.Ch2_RankEnable = 0x1;
 	memupd->FspmConfig.Ch2_DeviceWidth = 0x1;
 	memupd->FspmConfig.Ch2_DramDensity = 0x2;
 	memupd->FspmConfig.Ch2_Option = 0x3;
@@ -93,7 +93,7 @@ void mainboard_memory_init_params(FSPM_UPD *memupd)
 	memupd->FspmConfig.Ch2_TristateClk1 = 0x0;
 	memupd->FspmConfig.Ch2_Mode2N = 0x0;
 	memupd->FspmConfig.Ch2_OdtLevels = 0x0;
-	memupd->FspmConfig.Ch3_RankEnable = 0x3;
+	memupd->FspmConfig.Ch3_RankEnable = 0x1;
 	memupd->FspmConfig.Ch3_DeviceWidth = 0x1;
 	memupd->FspmConfig.Ch3_DramDensity = 0x2;
 	memupd->FspmConfig.Ch3_Option = 0x3;



More information about the coreboot-gerrit mailing list