[coreboot-gerrit] Patch merged into coreboot/master: libpayload: x86/exec - fix return value passing

gerrit at coreboot.org gerrit at coreboot.org
Wed Feb 15 21:56:17 CET 2017


the following patch was just integrated into master:
commit 901efea8abbb3131685fd69fd4ad7c5093c8cb3c
Author: Mathias Krause <minipli at googlemail.com>
Date:   Tue Feb 7 19:47:16 2017 +0100

    libpayload: x86/exec - fix return value passing
    
    The pointer to write the return value to is in %ecx, not %eax. Writing
    to (%eax) leads to memory corruptions as %eax holds the return value,
    e.g. would write zero to address zero for a "successful" returning
    payload.
    
    Change-Id: I82df27ae89a9e3d25f479ebdda2b50ea57565459
    Signed-off-by: Mathias Krause <minipli at googlemail.com>
    Reviewed-on: https://review.coreboot.org/18332
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See https://review.coreboot.org/18332 for details.

-gerrit



More information about the coreboot-gerrit mailing list