[coreboot-gerrit] Patch merged into coreboot/master: drivers/pc80/tpm: Update default acpi path

gerrit at coreboot.org gerrit at coreboot.org
Tue Feb 14 18:59:32 CET 2017


the following patch was just integrated into master:
commit 36537f113cf38f3b29cf5a51d563e8278f4683d8
Author: Tobias Diedrich <ranma+openocd at tdiedrich.de>
Date:   Fri Feb 10 00:28:45 2017 +0100

    drivers/pc80/tpm: Update default acpi path
    
    The existing default path of PCI0.LPCB is missing the \_SB prefix and prevents Linux from detecting the TPM.
    This is assuming that normally the LPCB device is most commonly on \_SB.PCI0.LPCB.
    
    SSDT excerpt without the patch:
    """
    DefinitionBlock ("", "SSDT", 2, "CORE  ", "COREBOOT", 0x0000002A)
    {
        External (_SB_.PCI0.GFX0, DeviceObj)
    [...]
        External (_SB_.PCI0.SATA, DeviceObj)
        External (PCI0.LPCB, DeviceObj)
    [...]
        Scope (PCI0.LPCB)
        {
            Device (TPM)
    [...]
        Scope (\_SB.PCI0.GFX0)
        {
            Method (_DOD, 0, NotSerialized)  // _DOD: Display Output Devices
    [...]
    """
    
    SSDT excerpt with the patch:
    """
    DefinitionBlock ("", "SSDT", 2, "CORE  ", "COREBOOT", 0x0000002A)
    {
        External (_SB_.PCI0.GFX0, DeviceObj)
    [...]
        External (_SB_.PCI0.LPCB, DeviceObj)
    [...]
        External (_SB_.PCI0.SATA, DeviceObj)
    [...]
        Scope (\_SB.PCI0.LPCB)
        {
            Device (TPM)
    [...]
        Scope (\_SB.PCI0.GFX0)
        {
            Method (_DOD, 0, NotSerialized)  // _DOD: Display Output Devices
    [...]
    """
    
    After the patch the TPM shows up in /sys/bus/acpi/devices/PNP0C31:00.
    Previously it was missing and not detected by the kernel.
    
    Change-Id: I615b4873ca829a859211403c84234d43d60f2243
    Signed-off-by: Tobias Diedrich <ranma+coreboot at tdiedrich.de>
    Reviewed-on: https://review.coreboot.org/18315
    Tested-by: build bot (Jenkins)
    Reviewed-by: Nicola Corna <nicola at corna.info>
    Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
    Reviewed-by: Duncan Laurie <dlaurie at chromium.org>


See https://review.coreboot.org/18315 for details.

-gerrit



More information about the coreboot-gerrit mailing list