[coreboot-gerrit] Patch set updated for coreboot: driver/i2c/max98927: add i2c driver for Maxim 98927 codec

Rizwan Qureshi (rizwan.qureshi@intel.com) gerrit at coreboot.org
Tue Feb 14 08:52:58 CET 2017


Rizwan Qureshi (rizwan.qureshi at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18211

-gerrit

commit 011205f0548119f3cd623658c09d1e9650858466
Author: Rizwan Qureshi <rizwan.qureshi at intel.com>
Date:   Fri Jan 13 22:17:01 2017 +0530

    driver/i2c/max98927: add i2c driver for Maxim 98927 codec
    
    Maxim 98927 kernel driver requires entries in the ACPI SSDT table,
    add a SSDT generator as part of this driver.
    
    BUG=None
    BRANCH=None
    TEST=After boot, dump and verify that the generated SSDT ACPI table has the
    required entries.
    
    Change-Id: Ic2d4d8449288bc00d085852220b2e1e7a208e9ef
    Signed-off-by: Naresh G Solanki <naresh.solanki at intel.com>
    Signed-off-by: Rizwan Qureshi <rizwan.qureshi at intel.com>
    Signed-off-by: M Naveen <naveen.m at intel.com>
    Signed-off-by: Dylan Reid <dgreid at chromium.org>
---
 src/drivers/i2c/max98927/Kconfig      |   2 +
 src/drivers/i2c/max98927/Makefile.inc |   1 +
 src/drivers/i2c/max98927/chip.h       |  30 ++++++++++
 src/drivers/i2c/max98927/max98927.c   | 108 ++++++++++++++++++++++++++++++++++
 4 files changed, 141 insertions(+)

diff --git a/src/drivers/i2c/max98927/Kconfig b/src/drivers/i2c/max98927/Kconfig
new file mode 100644
index 0000000..1007442
--- /dev/null
+++ b/src/drivers/i2c/max98927/Kconfig
@@ -0,0 +1,2 @@
+config DRIVERS_I2C_MAX98927
+	bool
diff --git a/src/drivers/i2c/max98927/Makefile.inc b/src/drivers/i2c/max98927/Makefile.inc
new file mode 100644
index 0000000..3bafee1
--- /dev/null
+++ b/src/drivers/i2c/max98927/Makefile.inc
@@ -0,0 +1 @@
+ramstage-$(CONFIG_DRIVERS_I2C_MAX98927) += max98927.c
diff --git a/src/drivers/i2c/max98927/chip.h b/src/drivers/i2c/max98927/chip.h
new file mode 100644
index 0000000..d63244f
--- /dev/null
+++ b/src/drivers/i2c/max98927/chip.h
@@ -0,0 +1,30 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2017 Intel Corp.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+/*
+ * Maxim MAX98927 audio codec devicetree bindings
+ */
+struct drivers_i2c_max98927_config {
+	/* I2C Bus Frequency in Hertz (default 400kHz) */
+	unsigned int bus_speed;
+	/* Set ‘1’ if I2S channel size is not 32bit. */
+	unsigned int interleave_mode;
+	/*Identifier for chips*/
+	unsigned int uid;
+	/* Device Description */
+	const char *desc;
+	/* ACPI Device Name */
+	const char *name;
+};
diff --git a/src/drivers/i2c/max98927/max98927.c b/src/drivers/i2c/max98927/max98927.c
new file mode 100644
index 0000000..1f5fabf
--- /dev/null
+++ b/src/drivers/i2c/max98927/max98927.c
@@ -0,0 +1,108 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2017 Intel Corporation.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <arch/acpi.h>
+#include <arch/acpi_device.h>
+#include <arch/acpigen.h>
+#include <console/console.h>
+#include <device/i2c.h>
+#include <device/device.h>
+#include <device/path.h>
+#include <stdint.h>
+#include <string.h>
+#include "chip.h"
+
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+
+#define MAX98927_ACPI_NAME	"MAXI"
+#define MAX98927_ACPI_HID	"MX98927"
+
+#define MAX98927_DP_INT(key, val) \
+	acpi_dp_add_integer(dp, "maxim," key, (val))
+
+static void max98927_fill_ssdt(struct device *dev)
+{
+	struct drivers_i2c_max98927_config *config = dev->chip_info;
+	const char *scope = acpi_device_scope(dev);
+	struct acpi_i2c i2c = {
+		.address = dev->path.i2c.device,
+		.mode_10bit = dev->path.i2c.mode_10bit,
+		.speed = config->bus_speed ? : I2C_SPEED_FAST,
+		.resource = scope,
+	};
+	struct acpi_dp *dp = NULL;
+
+	if (!dev->enabled || !scope)
+		return;
+
+	/* Device */
+	acpigen_write_scope(scope);
+	acpigen_write_device(acpi_device_name(dev));
+	acpigen_write_name_string("_HID", MAX98927_ACPI_HID);
+	acpigen_write_name_integer("_UID", config->uid);
+	acpigen_write_name_string("_DDN", config->desc);
+	acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);
+
+	/* Resources */
+	acpigen_write_name("_CRS");
+	acpigen_write_resourcetemplate_header();
+	acpi_device_write_i2c(&i2c);
+	acpigen_write_resourcetemplate_footer();
+
+	/* Device Properties */
+	dp = acpi_dp_new_table("_DSD");
+
+	acpi_dp_add_integer(dp, "interleave_mode", config->interleave_mode);
+
+	acpi_dp_write(dp);
+
+	acpigen_pop_len(); /* Device */
+	acpigen_pop_len(); /* Scope */
+
+	printk(BIOS_INFO, "%s: %s address 0%xh\n",
+	       acpi_device_path(dev), dev->chip_ops->name,
+	       dev->path.i2c.device);
+}
+
+static const char *max98927_acpi_name(struct device *dev)
+{
+	struct drivers_i2c_max98927_config *config = dev->chip_info;
+
+	if (config->name)
+		return config->name;
+
+	return MAX98927_ACPI_NAME;
+}
+#endif
+
+static struct device_operations max98927_ops = {
+	.read_resources		  = DEVICE_NOOP,
+	.set_resources		  = DEVICE_NOOP,
+	.enable_resources	  = DEVICE_NOOP,
+#if IS_ENABLED(CONFIG_HAVE_ACPI_TABLES)
+	.acpi_name                = &max98927_acpi_name,
+	.acpi_fill_ssdt_generator = &max98927_fill_ssdt,
+#endif
+};
+
+static void max98927_enable(struct device *dev)
+{
+	dev->ops = &max98927_ops;
+}
+
+struct chip_operations drivers_i2c_max98927_ops = {
+	CHIP_NAME("Maxim MAX98927 Codec")
+	.enable_dev = &max98927_enable
+};



More information about the coreboot-gerrit mailing list