[coreboot-gerrit] New patch to review for coreboot: Revert: soc/intel/skylake: Set FSP-S UPD PchHdaIDispCodecDisconnect to 1

Duncan Laurie (dlaurie@chromium.org) gerrit at coreboot.org
Mon Feb 13 20:45:56 CET 2017


Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18360

-gerrit

commit 953f074f05cb1a6531db57cf6f699333d0a9f3eb
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Mon Feb 13 20:45:54 2017 +0100

    Revert: soc/intel/skylake: Set FSP-S UPD PchHdaIDispCodecDisconnect to 1
    
    This reverts commit 32997fb0bcb9f4183789331a91fd83138776b96f.
    
    This change is breaking I2S audio on Kabylake platforms so
    revert the change to fix audio.
    
    BUG=chrome-os-partner:61548,chrome-os-partner:61009
    TEST=manual testing on Eve P1 system
    
    Change-Id: I3212c8be83078ed57e38501386605e67b87d5bd0
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/soc/intel/skylake/chip_fsp20.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/soc/intel/skylake/chip_fsp20.c b/src/soc/intel/skylake/chip_fsp20.c
index ebd3134..2aef65a 100644
--- a/src/soc/intel/skylake/chip_fsp20.c
+++ b/src/soc/intel/skylake/chip_fsp20.c
@@ -190,7 +190,6 @@ void platform_fsp_silicon_init_params_cb(FSPS_UPD *supd)
 	params->PchIshEnable = config->IshEnable;
 	params->PchHdaEnable = config->EnableAzalia;
 	params->PchHdaIoBufferOwnership = config->IoBufferOwnership;
-	params->PchHdaIDispCodecDisconnect = 1;
 	params->PchHdaDspEnable = config->DspEnable;
 	params->XdciEnable = config->XdciEnable;
 	params->Device4Enable = config->Device4Enable;



More information about the coreboot-gerrit mailing list