[coreboot-gerrit] New patch to review for coreboot: libpayload: x86/exec - fix libpayload API magic value

Mathias Krause (minipli@googlemail.com) gerrit at coreboot.org
Sat Feb 11 22:58:17 CET 2017


Mathias Krause (minipli at googlemail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18331

-gerrit

commit 51240742216c8aec6796e5655f11afd3e39e9144
Author: Mathias Krause <minipli at googlemail.com>
Date:   Tue Feb 7 18:59:27 2017 +0100

    libpayload: x86/exec - fix libpayload API magic value
    
    According to [1] the magic value passed to the payload should be
    0x12345678, not 12345678. Fix that.
    
    [1] https://www.coreboot.org/Payload_API
    
    Change-Id: I10a7f7b1a4aec100416c5e7e4ba7f8add10ef5c5
    Signed-off-by: Mathias Krause <minipli at googlemail.com>
---
 payloads/libpayload/arch/x86/exec.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/payloads/libpayload/arch/x86/exec.S b/payloads/libpayload/arch/x86/exec.S
index b632a55..c7595e9 100644
--- a/payloads/libpayload/arch/x86/exec.S
+++ b/payloads/libpayload/arch/x86/exec.S
@@ -66,7 +66,7 @@ i386_do_exec:
 	 * and argv are sane
 	 */
 
-	movl  $12345678, %ecx
+	movl  $0x12345678, %ecx
 	pushl %ecx
 
 	/* Jump to the code */



More information about the coreboot-gerrit mailing list