[coreboot-gerrit] New patch to review for coreboot: ec/lenovo/h8: Pulse the power LED during S3
Nicola Corna (nicola@corna.info)
gerrit at coreboot.org
Fri Feb 10 17:54:40 CET 2017
Nicola Corna (nicola at corna.info) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18325
-gerrit
commit be4e4a24887d94ee558091dc810f0eaa6038ef08
Author: Nicola Corna <nicola at corna.info>
Date: Fri Feb 10 13:05:04 2017 +0100
ec/lenovo/h8: Pulse the power LED during S3
Pulse the power LED during S3, like in the original Lenovo
firmware.
Change-Id: I2ac7dbc30609179e4ca5fc0a7b06763431fe3344
Signed-off-by: Nicola Corna <nicola at corna.info>
---
src/ec/lenovo/h8/acpi/systemstatus.asl | 4 ++--
src/ec/lenovo/h8/h8.h | 9 +++++----
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/ec/lenovo/h8/acpi/systemstatus.asl b/src/ec/lenovo/h8/acpi/systemstatus.asl
index e115842..378ce01 100644
--- a/src/ec/lenovo/h8/acpi/systemstatus.asl
+++ b/src/ec/lenovo/h8/acpi/systemstatus.asl
@@ -49,8 +49,8 @@ Scope (\_SI)
If (LEqual (Arg0, 3)) {
/* sleep state */
- /* power TLED off */
- \_SB.PCI0.LPCB.EC.TLED(0x00)
+ /* power TLED pulsing */
+ \_SB.PCI0.LPCB.EC.TLED(0xa0)
/* suspend TLED on */
\_SB.PCI0.LPCB.EC.TLED(0x87)
}
diff --git a/src/ec/lenovo/h8/h8.h b/src/ec/lenovo/h8/h8.h
index 290db91..5fe2bc1 100644
--- a/src/ec/lenovo/h8/h8.h
+++ b/src/ec/lenovo/h8/h8.h
@@ -60,15 +60,16 @@ void h8_mainboard_init_dock (void);
#define H8_TRACKPOINT_OFF 0x02
#define H8_TRACKPOINT_ON 0x03
+#define H8_USB_ALWAYS_ON 0x0d
+#define H8_USB_ALWAYS_ON_ENABLE 0x01
+#define H8_USB_ALWAYS_ON_AC_ONLY 0x0c
+
#define H8_LED_CONTROL 0x0c
#define H8_LED_CONTROL_OFF 0x00
#define H8_LED_CONTROL_ON 0x80
+#define H8_LED_CONTROL_PULSE 0xa0 /* Only on power LED */
#define H8_LED_CONTROL_BLINK 0xc0
-#define H8_USB_ALWAYS_ON 0x0d
-#define H8_USB_ALWAYS_ON_ENABLE 0x01
-#define H8_USB_ALWAYS_ON_AC_ONLY 0x0c
-
#define H8_LED_CONTROL_POWER_LED 0x00
#define H8_LED_CONTROL_BAT0_LED 0x01
#define H8_LED_CONTROL_BAT1_LED 0x02
More information about the coreboot-gerrit
mailing list