[coreboot-gerrit] New patch to review for coreboot: asus/m2v: Make _CRS methods serialized

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Fri Feb 10 15:04:57 CET 2017


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18323

-gerrit

commit 8234b22209a65b4679ff55a46e536c5a895fdd45
Author: Paul Menzel <pmenzel at molgen.mpg.de>
Date:   Fri Feb 10 14:49:29 2017 +0100

    asus/m2v: Make _CRS methods serialized
    
    Address the iasl 20160108-64 (Ubuntu 16.04) warnings below.
    
    ```
    Intel ACPI Component Architecture
    ASL+ Optimizing Compiler version 20160108-64
    Copyright (c) 2000 - 2016 Intel Corporation
    
    dsdt.aml    245:      Method (_CRS, 0, NotSerialized)
    Remark   2120 -                 ^ Control Method should be made Serialized (due to creation of named objects within)
    
    dsdt.aml    262:      Method (_CRS, 0, NotSerialized)
    Remark   2120 -                 ^ Control Method should be made Serialized (due to creation of named objects within)
    
    dsdt.aml    277:      Method (_CRS, 0, NotSerialized)
    Remark   2120 -                 ^ Control Method should be made Serialized (due to creation of named objects within)
    
    dsdt.aml    295:    Method(_CRS, 0) {
    Remark   2120 -              ^ Control Method should be made Serialized (due to creation of named objects within)
    ```
    
    Change-Id: Id5b0f33fba8ea25e4a6aa4f01c69a69aaf5aef23
    Signed-off-by: Paul Menzel <pmenzel at molgen.mpg.de>
---
 src/mainboard/asus/m2v/dsdt.asl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/mainboard/asus/m2v/dsdt.asl b/src/mainboard/asus/m2v/dsdt.asl
index bfa3ba4..0753082 100644
--- a/src/mainboard/asus/m2v/dsdt.asl
+++ b/src/mainboard/asus/m2v/dsdt.asl
@@ -348,7 +348,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "CORE  ", "COREBOOT", 1)
 					{
 						Return (0x0f)
 					}
-					Method (_CRS, 0, NotSerialized)
+					Method (_CRS, 0, Serialized)
 					{
 						Name (TMP, ResourceTemplate () {
 							IO (Decode16, 0x0060, 0x0060, 0x01, 0x01)
@@ -367,7 +367,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "CORE  ", "COREBOOT", 1)
 					{
 						Return (0x0f)
 					}
-					Method (_CRS, 0, NotSerialized)
+					Method (_CRS, 0, Serialized)
 					{
 						Name (TMP, ResourceTemplate () {
 						     IRQNoFlags () {12}
@@ -384,7 +384,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "CORE  ", "COREBOOT", 1)
 					{
 						Return (0x0f)
 					}
-					Method (_CRS, 0, NotSerialized)
+					Method (_CRS, 0, Serialized)
 					{
 						Name (TMP, ResourceTemplate () {
 							IO (Decode16, 0x0378, 0x0378, 0x01, 0x08)
@@ -406,7 +406,7 @@ DefinitionBlock ("DSDT.aml", "DSDT", 2, "CORE  ", "COREBOOT", 1)
 
 			External(TOM1) /* top of memory below 4GB */
 
-			Method(_CRS, 0) {
+			Method(_CRS, 0, Serialized) {
 				Name(TMP, ResourceTemplate() {
 					WordBusNumber(ResourceProducer, MinFixed, MaxFixed, PosDecode,
 						0x0000,             // Granularity



More information about the coreboot-gerrit mailing list