[coreboot-gerrit] New patch to review for coreboot: Skylake: Set FADT.8042 flag with CONFIG_DRIVERS_PS2_KEYBOARD

Jenny Tc (jenny.tc@intel.com) gerrit at coreboot.org
Wed Feb 8 09:58:14 CET 2017


Jenny Tc (jenny.tc at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18307

-gerrit

commit e03131f3dc980bf76d67ebfa76e2b3e8b705143e
Author: Jenny TC <jenny.tc at intel.com>
Date:   Tue Feb 7 14:16:54 2017 +0530

    Skylake: Set FADT.8042 flag with CONFIG_DRIVERS_PS2_KEYBOARD
    
    Kernel relies on FADT 8042 flag to enable/disable
    8042 interface. In coreboot, FADT 8042 flag cane be
    enabled/disabled based on the coreboot config
    CONFIG_DRIVERS_PS2_KEYBOARD
    
    BUG=chromium:61858
    TEST=Boot OS and verify FADT 8042 flag
    
    Change-Id: Ic80b3835cb5cccdde1203e24a58e28746b0196fc
    Signed-off-by: Jenny TC <jenny.tc at intel.com>
---
 src/soc/intel/skylake/acpi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/soc/intel/skylake/acpi.c b/src/soc/intel/skylake/acpi.c
index 54468d2..8488f52 100644
--- a/src/soc/intel/skylake/acpi.c
+++ b/src/soc/intel/skylake/acpi.c
@@ -268,7 +268,9 @@ void acpi_fill_fadt(acpi_fadt_t *fadt)
 	fadt->day_alrm = 0xd;
 	fadt->mon_alrm = 0x00;
 	fadt->century = 0x00;
-	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_DEVICES | ACPI_FADT_8042;
+	fadt->iapc_boot_arch = ACPI_FADT_LEGACY_DEVICES;
+	if (IS_ENABLED(CONFIG_DRIVERS_PS2_KEYBOARD))
+		fadt->iapc_boot_arch |= ACPI_FADT_8042;
 
 	fadt->flags = ACPI_FADT_WBINVD | ACPI_FADT_C1_SUPPORTED |
 			ACPI_FADT_C2_MP_SUPPORTED | ACPI_FADT_SLEEP_BUTTON |



More information about the coreboot-gerrit mailing list