[coreboot-gerrit] Patch set updated for coreboot: google/eve: Fix keyboard backlight enable in wake from G3

Duncan Laurie (dlaurie@chromium.org) gerrit at coreboot.org
Thu Feb 2 02:07:18 CET 2017


Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/18280

-gerrit

commit 18f9ba2dbc27dfbbac9e2a9faf6e45492e78bcac
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Jan 31 15:10:10 2017 -0800

    google/eve: Fix keyboard backlight enable in wake from G3
    
    The WAK_STS bit is not set in a wake from G3, so the check for this
    bit needs to only be done when checking for a wake from S3.
    
    This change correctly enables the keyboard backlight in wake from G3
    and only does not enable it during a wake from S3.
    
    BUG=chrome-os-partner:58666
    TEST=Use Refresh+Power to issue hard reset and ensure that the keyboard
    backlight turns on like it does when waking from S5.  Also force enter
    hibernate with Alt+VolumeUp+H and then power back up and ensure that
    the keyboard backlight is enabled when booting.
    
    Change-Id: I44045950e38aa5e5ae96a79385d604791852c7e6
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/mainboard/google/eve/bootblock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/eve/bootblock.c b/src/mainboard/google/eve/bootblock.c
index baca9c8..872825f 100644
--- a/src/mainboard/google/eve/bootblock.c
+++ b/src/mainboard/google/eve/bootblock.c
@@ -34,7 +34,7 @@ void bootblock_mainboard_init(void)
 	uint32_t pm1_sts = inl(ACPI_BASE_ADDRESS + PM1_STS);
 
 	/* Turn on keyboard backlight to indicate we are booting */
-	if ((pm1_sts & WAK_STS) && (acpi_sleep_from_pm1(pm1_cnt) != ACPI_S3))
+	if (!((pm1_sts & WAK_STS) && (acpi_sleep_from_pm1(pm1_cnt) == ACPI_S3)))
 		google_chromeec_kbbacklight(75);
 
 	early_config_gpio();



More information about the coreboot-gerrit mailing list