[coreboot-gerrit] Change in coreboot[master]: mb/google/fizz: Override IccMax settings
Gaggery Tsai (Code Review)
gerrit at coreboot.org
Thu Dec 28 15:14:14 CET 2017
Hello Kane Chen, build bot (Jenkins), Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/23020
to look at the new patch set (#2).
Change subject: mb/google/fizz: Override IccMax settings
......................................................................
mb/google/fizz: Override IccMax settings
According to Intel document #559100 KBL EDS v2.8, section 7.2
DC specifications, the IccMax setting for KBL-U, KBL-U42 and
Celeron are different. This patch sets Celeron as default SKU
in device tree and overrides the IccMax settings for KBL-U and
KBL-U42 at pre-FSPS.
+----------------+-------------+---------------+-------+-------+
| Domain/Setting | SA | IA | GTUS | GTS |
+----------------+-------------+---------------+-------+-------+
| IccMax | 6A(U42) | 64A(U42) | 31A | 31A |
| | 4.5A(Others)| 29A(Celeron) | 31A | 31A |(Default)
| | | 32A(i3/i5) | 31A | 31A |
+----------------+-------------+-------+-------+-------+-------+
BUG=b:71369428
BRANCH=None
TEST=emerge-fizz coreboot chromeos-bootimage & Ensure the KBL-U42,
KBL-U and Celeron SKUs are identified correctly and IccMax settings
are passed to FSPS correctly.
Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca
Signed-off-by: Gaggery Tsai <gaggery.tsai at intel.com>
---
A src/mainboard/google/fizz/common.h
M src/mainboard/google/fizz/devicetree.cb
M src/mainboard/google/fizz/mainboard.c
M src/mainboard/google/fizz/ramstage.c
4 files changed, 82 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/23020/2
--
To view, visit https://review.coreboot.org/23020
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I32ffe0cb73981850005b20fefb6664cfab74fbca
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 2
Gerrit-Owner: Gaggery Tsai <gaggery.tsai at intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Gaggery Tsai <gaggery.tsai at intel.com>
Gerrit-Reviewer: Kane Chen <kane.chen at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171228/b915f2d1/attachment.html>
More information about the coreboot-gerrit
mailing list