[coreboot-gerrit] Change in coreboot[master]: superio/ite/it8623e: add support for SIO chip ITE IT8623E

Gergely Kiss (Code Review) gerrit at coreboot.org
Wed Dec 27 12:00:45 CET 2017


Gergely Kiss has uploaded this change for review. ( https://review.coreboot.org/22999


Change subject: superio/ite/it8623e: add support for SIO chip ITE IT8623E
......................................................................

superio/ite/it8623e: add support for SIO chip ITE IT8623E

This change adds basic support for the SuperIO chip ITE IT8623E.
Due to the lack of a datasheet, defaults are shown as "not available (NA)"
in superiotool's register dump. LDNs defined in it8623e.h are
definitely correct and working as expected.

Change-Id: I50be1db4f238e6218a1d17c3669516fadf0ab4fa
Signed-off-by: Gergely Kiss <mail.gery at gmail.com>
---
M src/superio/ite/Makefile.inc
A src/superio/ite/it8623e/Kconfig
A src/superio/ite/it8623e/Makefile.inc
A src/superio/ite/it8623e/it8623e.h
A src/superio/ite/it8623e/superio.c
M util/superiotool/ite.c
6 files changed, 190 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/22999/1

diff --git a/src/superio/ite/Makefile.inc b/src/superio/ite/Makefile.inc
index f27a333..382dbd7 100644
--- a/src/superio/ite/Makefile.inc
+++ b/src/superio/ite/Makefile.inc
@@ -19,6 +19,7 @@
 ## include generic ite environment controller driver
 ramstage-$(CONFIG_SUPERIO_ITE_ENV_CTRL) += common/env_ctrl.c
 
+subdirs-y += it8623e
 subdirs-y += it8671f
 subdirs-y += it8712f
 subdirs-y += it8716f
diff --git a/src/superio/ite/it8623e/Kconfig b/src/superio/ite/it8623e/Kconfig
new file mode 100644
index 0000000..1b4fe4a
--- /dev/null
+++ b/src/superio/ite/it8623e/Kconfig
@@ -0,0 +1,20 @@
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2009 Ronald G. Minnich
+## Copyright (C) 2014 Edward O'Callaghan <eocallaghan at alterapraxis.com>
+## Copyright (C) 2017 Gergely Kiss <mail.gery at gmail.com>
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; version 2 of the License.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+
+config SUPERIO_ITE_IT8623E
+	bool
+	select SUPERIO_ITE_COMMON_ROMSTAGE
diff --git a/src/superio/ite/it8623e/Makefile.inc b/src/superio/ite/it8623e/Makefile.inc
new file mode 100644
index 0000000..2afaecf
--- /dev/null
+++ b/src/superio/ite/it8623e/Makefile.inc
@@ -0,0 +1,18 @@
+##
+## This file is part of the coreboot project.
+##
+## Copyright (C) 2006 Uwe Hermann <uwe at hermann-uwe.de>
+## Copyright (C) 2017 Gergely Kiss <mail.gery at gmail.com>
+##
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+##
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+## GNU General Public License for more details.
+##
+
+ramstage-$(CONFIG_SUPERIO_ITE_IT8623E) += superio.c
diff --git a/src/superio/ite/it8623e/it8623e.h b/src/superio/ite/it8623e/it8623e.h
new file mode 100644
index 0000000..25670c5
--- /dev/null
+++ b/src/superio/ite/it8623e/it8623e.h
@@ -0,0 +1,32 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2006 Uwe Hermann <uwe at hermann-uwe.de>
+ * Copyright (C) 2017 Gergely Kiss <mail.gery at gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#ifndef SUPERIO_ITE_IT8623E_H
+#define SUPERIO_ITE_IT8623E_H
+
+/* Datasheet not available. The list of LDNs might not be complete. */
+
+#define IT8623E_FDC  0x00 /* Floppy Controller */
+#define IT8623E_SP1  0x01 /* Com1 */
+#define IT8623E_SP2  0x02 /* Com2 */
+#define IT8623E_PP   0x03 /* Parallel port */
+#define IT8623E_EC   0x04 /* Environment controller */
+#define IT8623E_KBCK 0x05 /* PS/2 keyboard */
+#define IT8623E_KBCM 0x06 /* PS/2 mouse */
+#define IT8623E_GPIO 0x07 /* GPIO */
+
+#endif /* SUPERIO_ITE_IT8623E_H */
diff --git a/src/superio/ite/it8623e/superio.c b/src/superio/ite/it8623e/superio.c
new file mode 100644
index 0000000..b7b5342
--- /dev/null
+++ b/src/superio/ite/it8623e/superio.c
@@ -0,0 +1,75 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2006 Uwe Hermann <uwe at hermann-uwe.de>
+ * Copyright (C) 2007 Philipp Degler <pdegler at rumms.uni-mannheim.de>
+ * Copyright (C) 2016 Gergely Kiss <mail.gery at gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <device/device.h>
+#include <device/pnp.h>
+#include <pc80/keyboard.h>
+#include <arch/io.h>
+#include <stdlib.h>
+#include <superio/conf_mode.h>
+
+#include "it8623e.h"
+
+static void it8623e_init(struct device *dev)
+{
+
+	if (!dev->enabled)
+		return;
+
+	switch (dev->path.pnp.device) {
+	case IT8623E_EC:
+		break;
+	case IT8623E_KBCK:
+		set_kbc_ps2_mode();
+		pc_keyboard_init(NO_AUX_DEVICE);
+		break;
+	case IT8623E_KBCM:
+		break;
+	}
+}
+
+static struct device_operations ops = {
+	.read_resources   = pnp_read_resources,
+	.set_resources    = pnp_set_resources,
+	.enable_resources = pnp_enable_resources,
+	.enable           = pnp_alt_enable,
+	.init             = it8623e_init,
+	.ops_pnp_mode     = &pnp_conf_mode_870155_aa,
+};
+
+static struct pnp_info pnp_dev_info[] = {
+	{ &ops, IT8623E_FDC, PNP_IO0 | PNP_IRQ0 | PNP_DRQ0, 0x0ff8, },
+	{ &ops, IT8623E_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, },
+	{ &ops, IT8623E_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, },
+	{ &ops, IT8623E_PP, PNP_IO0 | PNP_IO1 | PNP_IRQ0 | PNP_DRQ0, 0x0ffc, 0x0ffc },
+	{ &ops, IT8623E_EC, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x0ff8, 0x0ff8, },
+	{ &ops, IT8623E_KBCK, PNP_IO0 | PNP_IO1 | PNP_IRQ0, 0x0fff, 0x0fff, },
+	{ &ops, IT8623E_KBCM, PNP_IRQ0, },
+	{ &ops, IT8623E_GPIO, PNP_IO0 | PNP_IO1 | PNP_IO2 | PNP_IRQ0, 0x0fff, 0x0ff8, 0x0ff8, },
+};
+
+static void enable_dev(struct device *dev)
+{
+	pnp_enable_devices(dev, &pnp_ops,
+		ARRAY_SIZE(pnp_dev_info), pnp_dev_info);
+}
+
+struct chip_operations superio_ite_it8623e_ops = {
+	CHIP_NAME("ITE IT8623E Super I/O")
+	.enable_dev = enable_dev,
+};
diff --git a/util/superiotool/ite.c b/util/superiotool/ite.c
index 43ccce1..c556df4 100644
--- a/util/superiotool/ite.c
+++ b/util/superiotool/ite.c
@@ -272,6 +272,50 @@
 			{0x30,0x60,0x61,0x62,0x63,0x70,0x71,EOT},
 			{0x00,0x00,0x6a,0x00,0x6e,0x01,0x01,EOT}},
 		{EOT}}},
+	{0x8623, "IT8623E", { /* Defaults are unknown for this chip as datasheet is not available */
+		{NOLDN, NULL,
+			{0x02,0x07,0x20,0x21,0x22,0x23,0x24,0x2b,0x2e,0x2f,EOT},
+			{NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,EOT}},
+		{0x0, "Floppy",
+			{0x30,0x60,0x61,0x70,0x74,0xf0,0xf1,EOT},
+			{NANA,NANA,NANA,NANA,NANA,NANA,NANA,EOT}},
+		{0x1, "COM1",
+			{0x30,0x60,0x61,0x70,0xf0,0xf1,EOT},
+			{NANA,NANA,NANA,NANA,NANA,NANA,EOT}},
+		{0x2, "COM2",
+			{0x30,0x60,0x61,0x70,0xf0,0xf1,EOT},
+			{NANA,NANA,NANA,NANA,NANA,NANA,EOT}},
+		{0x3, "Parallel port",
+			{0x30,0x60,0x61,0x62,0x63,0x70,0x74,0xf0,EOT},
+			{NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,EOT}},
+		{0x4, "Environment controller",
+			{0x30,0x60,0x61,0x62,0x63,0x70,0xf0,0xf1,0xf2,
+			 0xf3,0xf4,0xf5,0xf6,0xF9,0xFA,0xFB,EOT},
+			{NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,EOT}},
+		{0x5, "Keyboard",
+			{0x30,0x60,0x61,0x62,0x63,0x70,0x71,0xf0,EOT},
+			{NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,EOT}},
+		{0x6, "Mouse",
+			{0x30,0x70,0x71,0xf0,EOT},
+			{NANA,NANA,NANA,NANA,EOT}},
+		{0x7, "GPIO",
+			{0x25,0x26,0x27,0x28,0x29,0x2a,0x2c,0x2d,0x60,
+			 0x61,0x62,0x63,0x64,0x65,0x70,0x71,0x72,0x73,
+			 0x74,0xb0,0xb1,0xb2,0xb3,0xb4,0xb8,0xb9,0xba,
+			 0xbb,0xbc,0xbd,0xc0,0xc1,0xc2,0xc3,0xc4,0xc8,
+			 0xc9,0xca,0xcb,0xcc,0xcd,0xce,0xcf,0xe0,0xe1,
+			 0xe2,0xe3,0xe4,0xe9,0xf0,0xf1,0xf2,0xf3,0xf4,
+			 0xf5,0xf6,0xf7,0xf8,0xf9,0xfa,0xfb,EOT},
+			{NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,NANA,
+			 NANA,NANA,NANA,NANA,NANA,NANA,NANA,EOT}},
+		{EOT}}},
+
 	{0x8661, "IT8661F/IT8770F", {
 		{NOLDN, NULL,
 			{0x00,0x01,0x02,0x03,0x04,0x05,0x06,0x20,0x21,0x22,

-- 
To view, visit https://review.coreboot.org/22999
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50be1db4f238e6218a1d17c3669516fadf0ab4fa
Gerrit-Change-Number: 22999
Gerrit-PatchSet: 1
Gerrit-Owner: Gergely Kiss <mail.gery at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171227/2b587664/attachment-0001.html>


More information about the coreboot-gerrit mailing list