[coreboot-gerrit] Change in coreboot[master]: src/sb/intel/common/pirq_gen: Rework generating pin-route tables

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22979 )

Change subject: src/sb/intel/common/pirq_gen: Rework generating pin-route tables
......................................................................


Patch Set 5:

(3 comments)

Looks much better this way :)

Would it cause any trouble to include rcba_pirq.h from bd82x6x/pch.h?
It would safe us the Kconfig, or maybe I just miss some obstacle?

https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/acpi_pirq_gen.c
File src/southbridge/intel/common/acpi_pirq_gen.c:

https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/acpi_pirq_gen.c@59
PS5, Line 59: int_pin < 3
close


https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/acpi_pirq_gen.c@68
PS5, Line 68: (pirq - PIRQ_A)
Maybe it fits one line if you remove the parentheses...


https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/rcba_pirq.c
File src/southbridge/intel/common/rcba_pirq.c:

https://review.coreboot.org/#/c/22979/5/src/southbridge/intel/common/rcba_pirq.c@46
PS5, Line 46: pci_pin
cast to `enum pirq`?



-- 
To view, visit https://review.coreboot.org/22979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic68a91d0cb55942a4d928b30f73e1c779142420d
Gerrit-Change-Number: 22979
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 24 Dec 2017 01:53:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171224/f2a30f95/attachment.html>