[coreboot-gerrit] Change in coreboot[master]: src/sb/intel/common/pirq_gen: Rework generating pin-route map

Arthur Heymans (Code Review) gerrit at coreboot.org
Sun Dec 24 02:23:20 CET 2017


Hello build bot (Jenkins), Nico Huber, 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22979

to look at the new patch set (#4).

Change subject: src/sb/intel/common/pirq_gen: Rework generating pin-route map
......................................................................

src/sb/intel/common/pirq_gen: Rework generating pin-route map

This creates a pin-route matrix first and then generates the ACPI
entries based on that. This approach has the advantage of being
simpler (no need for checks on double entries) and requiring less
access to the pci config space.

A few thing that are also fixed:
* Don't declare DEFAULT_RCBA redundantly.
* Only loop over PCI devices on bus 0
* Add a license header to rcba_pirq.c
* Remove inappropriate use of typedefs

Change-Id: Ic68a91d0cb55942a4d928b30f73e1c779142420d
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/southbridge/intel/bd82x6x/Kconfig
M src/southbridge/intel/bd82x6x/pch.h
M src/southbridge/intel/common/acpi_pirq_gen.c
M src/southbridge/intel/common/acpi_pirq_gen.h
M src/southbridge/intel/common/rcba_pirq.c
M src/southbridge/intel/common/rcba_pirq.h
6 files changed, 83 insertions(+), 69 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/22979/4
-- 
To view, visit https://review.coreboot.org/22979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic68a91d0cb55942a4d928b30f73e1c779142420d
Gerrit-Change-Number: 22979
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171224/407cf491/attachment.html>


More information about the coreboot-gerrit mailing list