[coreboot-gerrit] Change in coreboot[master]: mainboard/hp: Add Eliteboot Revolve 810 G1

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22972 )

Change subject: mainboard/hp: Add Eliteboot Revolve 810 G1
......................................................................


Patch Set 2:

(3 comments)

What doesn't work or needs to be implemented ?

https://review.coreboot.org/#/c/22972/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22972/2//COMMIT_MSG@7
PS2, Line 7: mainboard/hp: Add Eliteboot Revolve 810 G1
Elitebook


https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/romstage.c
File src/mainboard/hp/revolve_810_g1/romstage.c:

https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/romstage.c@18
PS2, Line 18: #include <stdint.h>
please remove obsolete headers


https://review.coreboot.org/#/c/22972/2/src/mainboard/hp/revolve_810_g1/romstage.c@91
PS2, Line 91: 	void *spd_file = cbfs_boot_map_with_leak("spd.bin", CBFS_TYPE_SPD,
please don't leak the file



-- 
To view, visit https://review.coreboot.org/22972
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba9c361591697e6a2b3b7b485f7f1649c2a83524
Gerrit-Change-Number: 22972
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE <persmule at gmail.com>
Gerrit-Reviewer: Iru Cai <mytbk920423 at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 22 Dec 2017 08:46:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171222/e271fa5a/attachment.html>