[coreboot-gerrit] Change in coreboot[master]: soc/intel/gspi: Handle per-SoC differences in SPI_CS_CONTROL

Furquan Shaikh (Code Review) gerrit at coreboot.org
Wed Dec 20 19:23:56 CET 2017


Furquan Shaikh has uploaded a new patch set (#2). ( https://review.coreboot.org/22954 )

Change subject: soc/intel/gspi: Handle per-SoC differences in SPI_CS_CONTROL
......................................................................

soc/intel/gspi: Handle per-SoC differences in SPI_CS_CONTROL

Even though kaby lake and cannon lake are using the same GSPI
controller, bit meanings (for polarity and state) in SPI_CS_CONTROL
register are significantly different. This change provides and uses
SoC-specific callbacks to identify the right bits to be used for
polarity and state while programming the SPI_CS_CONTROL register.

BUG=b:70628116

Change-Id: Ic69321483a58bb29f939b0d8b37f33ca30eb53b8
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/soc/intel/cannonlake/gspi.c
M src/soc/intel/common/block/gspi/gspi.c
M src/soc/intel/common/block/include/intelblocks/gspi.h
M src/soc/intel/skylake/gspi.c
4 files changed, 102 insertions(+), 32 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/22954/2
-- 
To view, visit https://review.coreboot.org/22954
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic69321483a58bb29f939b0d8b37f33ca30eb53b8
Gerrit-Change-Number: 22954
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171220/3e22ca4a/attachment.html>


More information about the coreboot-gerrit mailing list