[coreboot-gerrit] Change in coreboot[master]: WIP soc/amd/common: Move LateInit earlier

Marshall Dawson (Code Review) gerrit at coreboot.org
Wed Dec 20 01:18:16 CET 2017


Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/22952 )

Change subject: WIP soc/amd/common: Move LateInit earlier
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22952/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22952/1//COMMIT_MSG@7
PS1, Line 7: WIP
I'm not yet confident this is allowed or a solid idea.  It moves the calls ahead of chip_ops.final() which calls southbridge_final() and fam15_finalize().

Perhaps another approach might be moving only the amdS3Save forward in time, but I don't know if there are any consequences to moving it ahead of amdinitlate.



-- 
To view, visit https://review.coreboot.org/22952
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia00c7b53e010679f51bd7f78f67382941bac4b33
Gerrit-Change-Number: 22952
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Comment-Date: Wed, 20 Dec 2017 00:18:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171220/8fdd25ca/attachment.html>


More information about the coreboot-gerrit mailing list