[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Program OPI PCR LPC registers

Lijian Zhao (Code Review) gerrit at coreboot.org
Tue Dec 19 04:26:51 CET 2017


Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/22941 )

Change subject: soc/intel/cannonlake: Program OPI PCR LPC registers
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/22941/2/src/soc/intel/common/block/lpc/lpc_lib.c
File src/soc/intel/common/block/lpc/lpc_lib.c:

https://review.coreboot.org/#/c/22941/2/src/soc/intel/common/block/lpc/lpc_lib.c@39
PS2, Line 39: S_ENABLED
That's not optional in build time?



-- 
To view, visit https://review.coreboot.org/22941
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I520afa8c5b2113efab7b224c7f3002fb30ff57f4
Gerrit-Change-Number: 22941
Gerrit-PatchSet: 2
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik at intel.com>
Gerrit-Reviewer: Caveh Jalali <caveh at google.com>
Gerrit-Reviewer: Hannah Williams <hannah.williams at intel.com>
Gerrit-Reviewer: John Zhao <john.zhao at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro at google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Dec 2017 03:26:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171219/71497562/attachment.html>


More information about the coreboot-gerrit mailing list