[coreboot-gerrit] Change in coreboot[master]: google/kahlee: Create mainboard_pirq_data

Richard Spiegel (Code Review) gerrit at coreboot.org
Tue Dec 19 01:34:36 CET 2017


Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22940 )

Change subject: google/kahlee: Create mainboard_pirq_data
......................................................................


Patch Set 1:

Local test results:
PCI IRQ: Found device 0:01.00 using PIN A
PCI Devfn (0x8) not found in pirq_data table
GFX does not has interrupt.
----------------------
PCI IRQ: Found device 0:08.00 using PIN A
PCI Devfn (0x40) not found in pirq_data table
PSP does not has interrupt.
----------------------
PCI IRQ: Found device 0:11.00 using PIN A
	Found this device in pirq_data table entry 8
Got IRQ 0x1F (disabled), perhaps this device was defined wrong?
SATA PIC mode wrong in mainboard_picr_data[]
----------------------
PCI IRQ: Found device 0:14.07 using PIN A
	Found this device in pirq_data table entry 6
Got IRQ 0x1F (disabled), perhaps this device was defined wrong?
SD PIC mode wrong in mainboard_picr_data[]
----------------------
Is PIC mode important? I believe Chromium uses APIC mode.


-- 
To view, visit https://review.coreboot.org/22940
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If07d2f54f06f6cf77566c43eddc8ee8a314e7a3a
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 19 Dec 2017 00:34:36 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171219/74e25e81/attachment.html>


More information about the coreboot-gerrit mailing list