[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP

Furquan Shaikh (Code Review) gerrit at coreboot.org
Sun Dec 17 11:35:43 CET 2017


Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22916


Change subject: mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP
......................................................................

mb/google/poppy/variants/nami: Fix GPIO configuration for DEVSLP

Nami uses DEVSLP1 and not DEVSLP0. This change fixes the GPIO
configuration error in the initial change 903472c
(mb/google/poppy/variants/nami: Add support for nami board).

BUG=b:70160119

Change-Id: Ifa181322011a4b8947ecd0fa44dcf790b0d8f657
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/poppy/variants/nami/gpio.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/22916/1

diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index e9e46c3..eaafe04 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -217,10 +217,10 @@
 	PAD_CFG_NC(GPP_E2),
 	/* E3  : CPU_GP0 ==> TRACKPAD_INT# */
 	PAD_CFG_GPI_APIC(GPP_E3, NONE, PLTRST),
-	/* E4  : SATA_DEVSLP0 ==> DEVSLP0 */
-	PAD_CFG_NF(GPP_E4, NONE, DEEP, NF1),
-	/* E5  : SATA_DEVSLP1 ==> NC(TP914) */
-	PAD_CFG_NC(GPP_E5),
+	/* E4  : SATA_DEVSLP0 ==> NC(TP914) */
+	PAD_CFG_NC(GPP_E4),
+	/* E5  : SATA_DEVSLP1 ==> DEVSLP1 */
+	PAD_CFG_NF(GPP_E5, NONE, DEEP, NF1),
 	/* E6  : SATA_DEVSLP2 ==> NC(TP915) */
 	PAD_CFG_NC(GPP_E6),
 	/* E7  : CPU_GP1 ==> TOUCHSCREEN_INT# */

-- 
To view, visit https://review.coreboot.org/22916
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa181322011a4b8947ecd0fa44dcf790b0d8f657
Gerrit-Change-Number: 22916
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171217/fd0f0383/attachment.html>


More information about the coreboot-gerrit mailing list