[coreboot-gerrit] Change in coreboot[master]: nb/intel/x4x/raminit: Fix programming dual channel registers

Arthur Heymans (Code Review) gerrit at coreboot.org
Sat Dec 16 23:17:58 CET 2017


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/22914

to look at the new patch set (#2).

Change subject: nb/intel/x4x/raminit: Fix programming dual channel registers
......................................................................

nb/intel/x4x/raminit: Fix programming dual channel registers

Some things in programming registers related to dual channel
interleaved operation were wrong.

This also adds some code that could in the future be used when me is
active and claims some memory for its UMA.

This also uses some more sensible variable names to clarify at least
some of the magic.

This fixes memtest86+ failing with some assymetric DIMM configuration.

TESTED on DG43GT: memtest86+ now succeeds on many more different DIMM
configuration setups (would instantly fail at addresses above 4G on
many configurations).

Change-Id: If84099d27100e57437bf214dc4cf975f67c2ea1f
Signed-off-by: Arthur Heymans <arthur at aheymans.xyz>
---
M src/northbridge/intel/x4x/raminit_ddr2.c
1 file changed, 51 insertions(+), 27 deletions(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/22914/2
-- 
To view, visit https://review.coreboot.org/22914
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If84099d27100e57437bf214dc4cf975f67c2ea1f
Gerrit-Change-Number: 22914
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171216/0bad87e3/attachment.html>


More information about the coreboot-gerrit mailing list