[coreboot-gerrit] Change in coreboot[master]: spi/tpm: Clear pending irqs during tpm2_init

Shelley Chen (Code Review) gerrit at coreboot.org
Sat Dec 16 00:34:44 CET 2017


Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/22909


Change subject: spi/tpm: Clear pending irqs during tpm2_init
......................................................................

spi/tpm: Clear pending irqs during tpm2_init

Seeing some instances were cr50 spi driver is starting a new
transaction without getting a ready interrupt from cr50, which means
that there are pending interrupts.  Clearing these to be sure there
are not any stale irqs for the next transaction.

BUG=b:69567837
BRANCH=None
TEST=run FAFT and see if any 0x2b recovery boots occur

Change-Id: Ie099da9f2b3c4da417648ae10a5ba356b7a093ff
Signed-off-by: Shelley Chen <shchen at chromium.org>
---
M src/drivers/spi/tpm/tpm.c
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/22909/1

diff --git a/src/drivers/spi/tpm/tpm.c b/src/drivers/spi/tpm/tpm.c
index e1fec28..ceec0b0 100644
--- a/src/drivers/spi/tpm/tpm.c
+++ b/src/drivers/spi/tpm/tpm.c
@@ -429,6 +429,9 @@
 
 	memcpy(spi_slave, spi_if, sizeof(*spi_if));
 
+	/* clear any pending irqs */
+	tis_plat_irq_status();
+
 	/*
 	 * 150 ms should be enough to synchronize with the TPM even under the
 	 * worst nested reset request conditions. In vast majority of cases

-- 
To view, visit https://review.coreboot.org/22909
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie099da9f2b3c4da417648ae10a5ba356b7a093ff
Gerrit-Change-Number: 22909
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171215/909e27e1/attachment.html>


More information about the coreboot-gerrit mailing list