[coreboot-gerrit] Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin

[David Schneider (Code Review)]

David Schneider has posted comments on this change. ( https://review.coreboot.org/22891 )

Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin
......................................................................


Patch Set 1:

(1 comment)

> Patch Set 1:
> 
> > Why not apply this change to all boards?  The code 1 bucket is oversized at the moment.
> 
> Because... that's... less correct? I mean, my Scarlet actually reads 42. And it doesn't matter anyway (until it does), but it seems like we should apply the tolerance we have equally on all sides, right?

Every other bucket is ~60 wide, with 30 on each side...except for bucket 1, which has 30 on the high side and 40 on the low side.

So using the new value for everything makes the buckets more consistent.

(And before you say that it makes bucket 0 relatively large, note that since we don't have 0.000V as a distinct bucket, bucket 0 is actually 1.5 buckets.  Such a theoretical -1 bucket, if we had it, would result in an additional threshold of 31.)

https://review.coreboot.org/#/c/22891/1/src/mainboard/google/gru/boardid.c
File src/mainboard/google/gru/boardid.c:

https://review.coreboot.org/#/c/22891/1/src/mainboard/google/gru/boardid.c@26
PS1, Line 26: 81
math looks right, but comment is wrong



-- 
To view, visit https://review.coreboot.org/22891
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855
Gerrit-Change-Number: 22891
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: David Schneider <dnschneid at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Philip Chen <philipchen at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 15 Dec 2017 02:30:14 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171215/16c4f88b/attachment.html>