[coreboot-gerrit] Change in coreboot[master]: google/gru: Adjust to incorrect strapping resistors on Kevin

[Julius Werner (Code Review)]

Hello Lin Huang, David Schneider, Philip Chen,

I'd like you to do a code review. Please visit

    https://review.coreboot.org/22891

to review the following change.


Change subject: google/gru: Adjust to incorrect strapping resistors on Kevin
......................................................................

google/gru: Adjust to incorrect strapping resistors on Kevin

It seems that RAM code 0 has been strapped with an incorrect resistor on
Kevin. The resulting voltage divide still puts it well within the ADC
value bucket reserved for that slot, but a little closer to the edge
than necessary. While this doesn't seem to cause any immediate problems
on its own, it still doesn't hurt to fix it (if only for the
documentation value).

On other boards (at least on my Scarlet) the strapping seems to be
correct.

Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/gru/boardid.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/22891/1

diff --git a/src/mainboard/google/gru/boardid.c b/src/mainboard/google/gru/boardid.c
index 6d18648..22730a2 100644
--- a/src/mainboard/google/gru/boardid.c
+++ b/src/mainboard/google/gru/boardid.c
@@ -22,7 +22,11 @@
 static const int id_readings[] = {
 /*	ID : Volts : ADC value :    Bucket	*/
 /*	==   =====   =========    ==========	*/
+#if IS_ENABLED(CONFIG_BOARD_GOOGLE_KEVIN)
+/*	 0 : 0.109V:        62 :    0 -   81	*/	91,
+#else
 /*	 0 : 0.074V:        42 :    0 -   81	*/	81,
+#endif
 /*	 1 : 0.211V:       120 :   82 -  150	*/	150,
 /*	 2 : 0.319V:       181 :  151 -  211	*/	211,
 /*	 3 : 0.427V:       242 :  212 -  274	*/	274,

-- 
To view, visit https://review.coreboot.org/22891
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic5199834fbeaf734e725ff45b04f45eefe149855
Gerrit-Change-Number: 22891
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: David Schneider <dnschneid at chromium.org>
Gerrit-Reviewer: Lin Huang <hl at rock-chips.com>
Gerrit-Reviewer: Philip Chen <philipchen at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171215/25954019/attachment-0001.html>