[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Move InitPost printed results

[Marshall Dawson (Code Review)]

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/22887


Change subject: soc/amd/common: Move InitPost printed results
......................................................................

soc/amd/common: Move InitPost printed results

Make a static function that can report the AmdInitPost() results.  This
makes it easier to keep lines within 80 columns.  Clean up surrounding
source.

BUG=b:62240746
TEST=Build and boot Kahlee

Change-Id: I6d288e76e7510528659436e61fdfa1d5db01f06c
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/soc/amd/common/block/pi/agesawrapper.c
1 file changed, 46 insertions(+), 25 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/22887/1

diff --git a/src/soc/amd/common/block/pi/agesawrapper.c b/src/soc/amd/common/block/pi/agesawrapper.c
index 4a3e527..a4e1a17 100644
--- a/src/soc/amd/common/block/pi/agesawrapper.c
+++ b/src/soc/amd/common/block/pi/agesawrapper.c
@@ -133,6 +133,43 @@
 	return status;
 }
 
+static void print_init_post_settings(AMD_POST_PARAMS *parms)
+{
+	u64 syslimit, bottomio, uma_size, uma_start;
+	const char *uma_auto = "UMA_AUTO";
+	const char *uma_specified = "UMA_SPECIFIED";
+	const char *uma_none = "UMA_NONE";
+	const char *uma_unknown = "unknown";
+	const char *mode;
+
+	switch (parms->MemConfig.UmaMode) {
+	case UMA_AUTO:
+		mode = uma_auto;
+		break;
+	case UMA_SPECIFIED:
+		mode = uma_specified;
+		break;
+	case UMA_NONE:
+		mode = uma_none;
+		break;
+	default:
+		mode = uma_unknown;
+		break;
+	}
+
+	syslimit = (u64)parms->MemConfig.SysLimit * 64 * KiB;
+	bottomio = (u64)parms->MemConfig.BottomIo * 64 * KiB;
+
+	uma_size = (u64)parms->MemConfig.UmaSize * 64 * KiB;
+	uma_start = (u64)parms->MemConfig.UmaBase * 64 * KiB;
+
+	printk(BIOS_SPEW, "AGESA set: umamode %s\n", mode);
+	printk(BIOS_SPEW, "         : syslimit 0x%llx, bottomio 0x%08llx\n",
+					syslimit, bottomio);
+	printk(BIOS_SPEW, "         : uma size %lluMB, uma start 0x%08llx\n",
+					uma_size / MiB, uma_start);
+}
+
 AGESA_STATUS agesawrapper_amdinitpost(void)
 {
 	AGESA_STATUS status;
@@ -168,35 +205,19 @@
 	status = AmdInitPost (PostParams);
 	timestamp_add_now(TS_AGESA_INIT_POST_DONE);
 
-	/* If UMA is enabled we currently have it below TOP_MEM as well.
+	/*
+	 * If UMA is enabled we currently have it below TOP_MEM as well.
 	 * UMA may or may not be cacheable, so Sub4GCacheTop could be
-	 * higher than UmaBase. With UMA_NONE we see UmaBase==0. */
+	 * higher than UmaBase. With UMA_NONE we see UmaBase==0.
+	 */
+	uintptr_t top;
 	if (PostParams->MemConfig.UmaBase)
-		backup_top_of_low_cacheable(PostParams->MemConfig.UmaBase << 16);
+		top = PostParams->MemConfig.UmaBase << 16;
 	else
-		backup_top_of_low_cacheable(PostParams->MemConfig.Sub4GCacheTop);
+		top = PostParams->MemConfig.Sub4GCacheTop;
+	backup_top_of_low_cacheable(top);
 
-
-	printk(
-			BIOS_SPEW,
-			"setup_uma_memory: umamode %s\n",
-			(PostParams->MemConfig.UmaMode == UMA_AUTO) ? "UMA_AUTO" :
-			(PostParams->MemConfig.UmaMode == UMA_SPECIFIED) ? "UMA_SPECIFIED" :
-			(PostParams->MemConfig.UmaMode == UMA_NONE) ? "UMA_NONE" :
-			"unknown"
-	);
-	printk(
-			BIOS_SPEW,
-			"setup_uma_memory: syslimit 0x%08llX, bottomio 0x%08lx\n",
-			(unsigned long long)(PostParams->MemConfig.SysLimit) << 16,
-			(unsigned long)(PostParams->MemConfig.BottomIo) << 16
-	);
-	printk(
-			BIOS_SPEW,
-			"setup_uma_memory: uma size %luMB, uma start 0x%08lx\n",
-			(unsigned long)(PostParams->MemConfig.UmaSize) >> (20 - 16),
-			(unsigned long)(PostParams->MemConfig.UmaBase) << 16
-	);
+	print_init_post_settings(PostParams);
 
 	if (status != AGESA_SUCCESS)
 		agesawrapper_readeventlog(PostParams->StdHeader.HeapStatus);

-- 
To view, visit https://review.coreboot.org/22887
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d288e76e7510528659436e61fdfa1d5db01f06c
Gerrit-Change-Number: 22887
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171215/19ca5972/attachment.html>