[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Uncomment InitLate AmdReleaseStruct()
Marshall Dawson (Code Review)
gerrit at coreboot.org
Fri Dec 15 01:38:09 CET 2017
Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/22888
Change subject: soc/amd/common: Uncomment InitLate AmdReleaseStruct()
......................................................................
soc/amd/common: Uncomment InitLate AmdReleaseStruct()
The AGESA spec states that "Failure to release a structure can cause
undesired outcomes." Uncomment the call so that the structure is
released.
BUG=b:70671742
TEST=Build and boot Kahlee, inspect console log
Change-Id: Ib1ff94ec2acdc845c5e4b4ed7088061cfc0c55f3
Signed-off-by: Marshall Dawson <marshalldawson3rd at gmail.com>
---
M src/soc/amd/common/block/pi/agesawrapper.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/22888/1
diff --git a/src/soc/amd/common/block/pi/agesawrapper.c b/src/soc/amd/common/block/pi/agesawrapper.c
index a4e1a17..87dfd56 100644
--- a/src/soc/amd/common/block/pi/agesawrapper.c
+++ b/src/soc/amd/common/block/pi/agesawrapper.c
@@ -365,7 +365,7 @@
car_get_var(AcpiWheaMce), car_get_var(AcpiWheaCmc),
car_get_var(AcpiAlib), car_get_var(AcpiIvrs));
- /* AmdReleaseStruct (&AmdParamStruct); */
+ AmdReleaseStruct(&AmdParamStruct);
return Status;
}
--
To view, visit https://review.coreboot.org/22888
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1ff94ec2acdc845c5e4b4ed7088061cfc0c55f3
Gerrit-Change-Number: 22888
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171215/d2342dfa/attachment-0001.html>
More information about the coreboot-gerrit
mailing list