[coreboot-gerrit] Change in coreboot[master]: mb/google/nami: Revise speaker enable pin from A22 to A23

Gaggery Tsai (Code Review) gerrit at coreboot.org
Thu Dec 14 10:15:11 CET 2017


Gaggery Tsai has uploaded this change for review. ( https://review.coreboot.org/22863


Change subject: mb/google/nami: Revise speaker enable pin from A22 to A23
......................................................................

mb/google/nami: Revise speaker enable pin from A22 to A23

According to schematic, the speaker enabling pin is GPP_A23.

BUG=b:70646770
TEST=emerge-nami coreboot

Change-Id: I4661749d0852f25e855d84f9416db67867545cb4
Signed-off-by: Gaggery Tsai <gaggery.tsai at intel.com>
---
M src/mainboard/google/poppy/variants/nami/gpio.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/22863/1

diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index 81fb129..e9e46c3 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -57,10 +57,10 @@
 	PAD_CFG_NC(GPP_A20),
 	/* A21 : ISH_GP3 ==> NC */
 	PAD_CFG_NC(GPP_A21),
-	/* A22 : ISH_GP4 ==> PCH_SPK_EN */
-	PAD_CFG_GPO(GPP_A22, 1, DEEP),
-	/* A23 : ISH_GP5 ==> NC */
-	PAD_CFG_NC(GPP_A23),
+	/* A22 : ISH_GP4 ==> NC */
+	PAD_CFG_NC(GPP_A22),
+	/* A23 : ISH_GP5 ==> PCH_SPK_EN */
+	PAD_CFG_GPO(GPP_A23, 1, DEEP),
 
 	/* B0  : CORE_VID0 ==> NC(T3) */
 	PAD_CFG_NC(GPP_B0),

-- 
To view, visit https://review.coreboot.org/22863
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4661749d0852f25e855d84f9416db67867545cb4
Gerrit-Change-Number: 22863
Gerrit-PatchSet: 1
Gerrit-Owner: Gaggery Tsai <gaggery.tsai at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171214/cee38bbf/attachment.html>


More information about the coreboot-gerrit mailing list