[coreboot-gerrit] Change in coreboot[master]: Snappy: hack Melfas kernel driver to prevent VTSP power drop

Kevin Chiu (Code Review) gerrit at coreboot.org
Thu Dec 14 00:41:06 CET 2017


Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/22858


Change subject: Snappy: hack Melfas kernel driver to prevent VTSP power drop
......................................................................

Snappy: hack Melfas kernel driver to prevent VTSP power drop

Melfas kernel TS driver (melfas_mip4.c) will look up "ce"
GPIO during driver probe in ACPI _DSD.
But FW does not report "ce-gpios" but "enable-gpios" in _DSD.
Kernel will obtain GPIO from _CRS by index "0" without ID.

Melfas driver does not have separate condition
for MIT-410 so driver will set TS IC power off in probe.

FW now may need to add back "reset" pin in order to hack
this condition to let Melfas driver get "useless" GPIO
so TS IC power (VTSP) will not drop during driver probe.

BUG=b:70149336
BRANCH=reef
TEST=emerge-snappy coreboot
Change-Id: Icf0451ff0c3df97cb2474e30542a2f46ba67d82a
Signed-off-by: Kevin Chiu <Kevin.Chiu at quantatw.com>
---
M src/mainboard/google/reef/variants/snappy/devicetree.cb
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/22858/1

diff --git a/src/mainboard/google/reef/variants/snappy/devicetree.cb b/src/mainboard/google/reef/variants/snappy/devicetree.cb
index f40c330..4b0981e 100644
--- a/src/mainboard/google/reef/variants/snappy/devicetree.cb
+++ b/src/mainboard/google/reef/variants/snappy/devicetree.cb
@@ -198,6 +198,8 @@
 				register "desc" = ""Melfas Touchscreen""
 				register "irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)"
 				register "probed" = "1"
+				register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
+				register "reset_delay_ms" = "1"
 				register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_152)"
 				register "enable_delay_ms" = "5"
 				register "has_power_resource" = "1"

-- 
To view, visit https://review.coreboot.org/22858
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf0451ff0c3df97cb2474e30542a2f46ba67d82a
Gerrit-Change-Number: 22858
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu <Kevin.Chiu at quantatw.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171213/7341c8cc/attachment-0001.html>


More information about the coreboot-gerrit mailing list