[coreboot-gerrit] Change in coreboot[master]: fix src/soc/amd/common/agesawrapper_call.h

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22850 )

Change subject: fix src/soc/amd/common/agesawrapper_call.h
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/22850/1/src/soc/amd/common/block/pi/amd_late_init.c
File src/soc/amd/common/block/pi/amd_late_init.c:

https://review.coreboot.org/#/c/22850/1/src/soc/amd/common/block/pi/amd_late_init.c@a31
PS1, Line 31: 
> Instead of adding the printks, this could have just been changed to:
No reason at all, and I actually did not delete it. I just thought that for someone reading it, having it fully expanded was clearer than do_agesawrapper() which would require the person to search the function and see that it expanded into 2 prints and one AGESA call.



-- 
To view, visit https://review.coreboot.org/22850
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic51917d3961a51d4e725ff45b04f45eefe149855
Gerrit-Change-Number: 22850
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 13 Dec 2017 22:36:33 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171213/3d9a8210/attachment.html>