[coreboot-gerrit] Change in coreboot[master]: drivers/pc80/tpm: Remove unused ACPI opregion

[Duncan Laurie (Code Review)]

Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/22854


Change subject: drivers/pc80/tpm: Remove unused ACPI opregion
......................................................................

drivers/pc80/tpm: Remove unused ACPI opregion

The opregion and fields are left over from when ACPI ASL code was
reading registers to determine the current setup.  Now that the
ACPI device is generated with the correct information already this
code is not used at all and can be removed from the tree.

Change-Id: If89d90cc7105ed21e2134ac99224f6f8214cc8ad
Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
M src/drivers/pc80/tpm/tpm.c
1 file changed, 0 insertions(+), 32 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/22854/1

diff --git a/src/drivers/pc80/tpm/tpm.c b/src/drivers/pc80/tpm/tpm.c
index c0afd4c..3e65bfd 100644
--- a/src/drivers/pc80/tpm/tpm.c
+++ b/src/drivers/pc80/tpm/tpm.c
@@ -872,8 +872,6 @@
 {
 	const char *path = acpi_device_path(dev->bus->dev);
 	u32 arg;
-	struct opregion opreg = OPREGION("TREG", SYSTEMMEMORY,
-					CONFIG_TPM_TIS_BASE_ADDRESS, 0x5000);
 
 	if (!path) {
 		path = "\\_SB_.PCI0.LPCB";
@@ -887,37 +885,7 @@
 	acpigen_write_name("_HID");
 	acpigen_emit_eisaid("PNP0C31");
 
-	acpigen_write_name("_CID");
-	acpigen_emit_eisaid("PNP0C31");
-
 	acpigen_write_name_integer("_UID", 1);
-
-	acpigen_write_opregion(&opreg);
-
-	struct fieldlist tpm_field_list[] = {
-		/*
-		 * TPM_INT_ENABLE_0
-		 * bit 0 : dataAvailIntEnable,
-		 * bit 1 : stsValidIntEnable,
-		 * bit 2 : localityChangeIntEnable,
-		 * bit 3:4 typePolarity.
-		 */
-		FIELDLIST_OFFSET(0x8),
-		FIELDLIST_NAMESTR("INTE", 3),
-		FIELDLIST_NAMESTR("ITPL", 2),
-
-		/* TPM_INT_VECTOR_0 */
-		FIELDLIST_OFFSET(0xC),
-		FIELDLIST_NAMESTR("IVEC", 4),
-
-		/* TPM_DID_VID */
-		FIELDLIST_OFFSET(0xf00),
-		FIELDLIST_NAMESTR("DVID", 32),
-	};
-
-	acpigen_write_field(opreg.name, tpm_field_list,
-			ARRAY_SIZE(tpm_field_list),
-			FIELD_BYTEACC | FIELD_NOLOCK | FIELD_PRESERVE);
 
 	u32 did_vid = tpm_read_did_vid(0);
 	if (did_vid > 0 && did_vid < 0xffffffff)

-- 
To view, visit https://review.coreboot.org/22854
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If89d90cc7105ed21e2134ac99224f6f8214cc8ad
Gerrit-Change-Number: 22854
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171213/e20307f5/attachment-0001.html>