[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nami: Fix GPIO config for PCH_SPK_EN
Furquan Shaikh (Code Review)
gerrit at coreboot.org
Wed Dec 13 19:07:52 CET 2017
Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22844
Change subject: mb/google/poppy/variants/nami: Fix GPIO config for PCH_SPK_EN
......................................................................
mb/google/poppy/variants/nami: Fix GPIO config for PCH_SPK_EN
PCH_SPK_EN uses GPP_A23 and not GPP_A22. This change fixes the gpio
configuration error in the initial CL:22703.
BUG=b:70160119
Change-Id: I90d9c009369c53cfec47fe77356e181d5ecf7ad5
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/google/poppy/variants/nami/gpio.c
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/22844/1
diff --git a/src/mainboard/google/poppy/variants/nami/gpio.c b/src/mainboard/google/poppy/variants/nami/gpio.c
index 81fb129..e9e46c3 100644
--- a/src/mainboard/google/poppy/variants/nami/gpio.c
+++ b/src/mainboard/google/poppy/variants/nami/gpio.c
@@ -57,10 +57,10 @@
PAD_CFG_NC(GPP_A20),
/* A21 : ISH_GP3 ==> NC */
PAD_CFG_NC(GPP_A21),
- /* A22 : ISH_GP4 ==> PCH_SPK_EN */
- PAD_CFG_GPO(GPP_A22, 1, DEEP),
- /* A23 : ISH_GP5 ==> NC */
- PAD_CFG_NC(GPP_A23),
+ /* A22 : ISH_GP4 ==> NC */
+ PAD_CFG_NC(GPP_A22),
+ /* A23 : ISH_GP5 ==> PCH_SPK_EN */
+ PAD_CFG_GPO(GPP_A23, 1, DEEP),
/* B0 : CORE_VID0 ==> NC(T3) */
PAD_CFG_NC(GPP_B0),
--
To view, visit https://review.coreboot.org/22844
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I90d9c009369c53cfec47fe77356e181d5ecf7ad5
Gerrit-Change-Number: 22844
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171213/fdc65f7a/attachment.html>
More information about the coreboot-gerrit
mailing list