[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Initialize DDI-A lane in absence of Pre-OS grap...

Lijian Zhao (Code Review) gerrit at coreboot.org
Sat Dec 9 22:55:26 CET 2017


Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/22799 )

Change subject: soc/intel/cannonlake: Initialize DDI-A lane in absence of Pre-OS graphics.
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/22799/1/src/soc/intel/cannonlake/graphics.c
File src/soc/intel/cannonlake/graphics.c:

https://review.coreboot.org/#/c/22799/1/src/soc/intel/cannonlake/graphics.c@33
PS1, Line 33: 	u32 ddi_buf_ctl;
uint32_t


https://review.coreboot.org/#/c/22799/1/src/soc/intel/cannonlake/graphics.c@59
PS1, Line 59: 	u32 reg32 = pci_read_config32(dev, PCI_COMMAND);
uint32_t



-- 
To view, visit https://review.coreboot.org/22799
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6353020f892f2d7b75997eace88b3074adc32aef
Gerrit-Change-Number: 22799
Gerrit-PatchSet: 1
Gerrit-Owner: Abhay Kumar <abhay.kumar at intel.com>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 09 Dec 2017 21:55:26 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171209/8f16a017/attachment.html>


More information about the coreboot-gerrit mailing list