[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/name: Implement variant_memory_params

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22779


Change subject: mb/google/poppy/variants/name: Implement variant_memory_params
......................................................................

mb/google/poppy/variants/name: Implement variant_memory_params

This change provides implementation of variant_memory_params for
nami. Since it uses DDR4 memory, DQ-DQS mapping table is not
required. Also, Rcomp resistor values are provided based on SDP v/s
DDP memory.

BUG=b:70188937

Change-Id: Ic1d0cfdb7d8b02fa0be0a4c54b20057a4c2fc3ce
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/mainboard/google/poppy/variants/nami/Makefile.inc
A src/mainboard/google/poppy/variants/nami/memory.c
2 files changed, 50 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/22779/1

diff --git a/src/mainboard/google/poppy/variants/nami/Makefile.inc b/src/mainboard/google/poppy/variants/nami/Makefile.inc
index 0050a3b..bbcb7d3 100644
--- a/src/mainboard/google/poppy/variants/nami/Makefile.inc
+++ b/src/mainboard/google/poppy/variants/nami/Makefile.inc
@@ -3,5 +3,7 @@
 
 bootblock-y += gpio.c
 
+romstage-y += memory.c
+
 ramstage-y += gpio.c
 ramstage-y += pl2.c
diff --git a/src/mainboard/google/poppy/variants/nami/memory.c b/src/mainboard/google/poppy/variants/nami/memory.c
new file mode 100644
index 0000000..dec7626
--- /dev/null
+++ b/src/mainboard/google/poppy/variants/nami/memory.c
@@ -0,0 +1,48 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2017 Google Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include <baseboard/variants.h>
+#include <string.h>
+
+/* Rcomp resistor */
+static const u16 rcomp_resistor_ddp[] = { 121, 81, 100 };
+static const u16 rcomp_resistor_sdp[] = { 200, 81, 100 };
+
+/* Rcomp target */
+static const u16 rcomp_target[] = { 100, 40, 20, 20, 26 };
+
+/* Memory ids are 1-indexed, so subtract 1 to use 0-indexed values in bitmap. */
+#define MEM_ID(x)	(1 << ((x) - 1))
+
+/* Bitmap to indicate which memory ids are using DDP. */
+static const uint16_t ddp_bitmap = MEM_ID(4);
+
+void variant_memory_params(struct memory_params *p)
+{
+	memset(p, 0, sizeof(*p));
+	p->type = MEMORY_DDR4;
+
+	/* Rcomp resistor values are different for SDP and DDP. */
+	if (ddp_bitmap & MEM_ID(variant_memory_sku())) {
+		p->rcomp_resistor = rcomp_resistor_ddp;
+		p->rcomp_resistor_size = sizeof(rcomp_resistor_ddp);
+	} else {
+		p->rcomp_resistor = rcomp_resistor_sdp;
+		p->rcomp_resistor_size = sizeof(rcomp_resistor_sdp);
+	}
+
+	p->rcomp_target = rcomp_target;
+	p->rcomp_target_size = sizeof(rcomp_target);
+}

-- 
To view, visit https://review.coreboot.org/22779
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1d0cfdb7d8b02fa0be0a4c54b20057a4c2fc3ce
Gerrit-Change-Number: 22779
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171208/ff66c238/attachment.html>