[coreboot-gerrit] Change in coreboot[master]: google/gru: Change Scarlet SKU ID pins to pull-ups
Julius Werner (Code Review)
gerrit at coreboot.org
Thu Dec 7 22:00:58 CET 2017
Julius Werner has uploaded this change for review. ( https://review.coreboot.org/22775
Change subject: google/gru: Change Scarlet SKU ID pins to pull-ups
......................................................................
google/gru: Change Scarlet SKU ID pins to pull-ups
These pins need to be pull-ups. I forgot.
BUG=b:69373077
Change-Id: I9314617e01d35898254984529f269d4442e736f1
Signed-off-by: Julius Werner <jwerner at chromium.org>
---
M src/mainboard/google/gru/boardid.c
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/22775/1
diff --git a/src/mainboard/google/gru/boardid.c b/src/mainboard/google/gru/boardid.c
index 9dc7b05..af56f1d 100644
--- a/src/mainboard/google/gru/boardid.c
+++ b/src/mainboard/google/gru/boardid.c
@@ -88,6 +88,7 @@
gpio_t pins[3] = {[2] = GPIO(3, D, 6), [1] = GPIO(3, D, 5),
[0] = GPIO(3, D, 4)}; /* GPIO3_D4 is LSB */
- sku_id = gpio_base2_value(pins, ARRAY_SIZE(pins));
+
+ sku_id = gpio_pullup_base2_value(pins, ARRAY_SIZE(pins));
return sku_id;
}
--
To view, visit https://review.coreboot.org/22775
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9314617e01d35898254984529f269d4442e736f1
Gerrit-Change-Number: 22775
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171207/51826fbc/attachment-0001.html>
More information about the coreboot-gerrit
mailing list