[coreboot-gerrit] Change in coreboot[master]: soc/amd/common: Move files to common/block

Richard Spiegel (Code Review) gerrit at coreboot.org
Thu Dec 7 20:19:35 CET 2017


Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/22765 )

Change subject: soc/amd/common: Move files to common/block
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/pci/amd_pci_util.c
File src/soc/amd/common/block/pci/amd_pci_util.c:

https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/pci/amd_pci_util.c@177
PS1, Line 177: printk
> Remove the added space please.
Ok, my mistake.


https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/spi/Kconfig
File src/soc/amd/common/block/spi/Kconfig:

https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/spi/Kconfig@5
PS1, Line 5: This option allows the SOC to use AMD common PCI utilities
           : 	  to program IRQ. If this option is not used, the SOC must
           : 	  implement these functions separately.
> Wrong help message.
Ok, will fix it.



-- 
To view, visit https://review.coreboot.org/22765
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f965afa21124d4874d3b7bfe0f404a58b070e23
Gerrit-Change-Number: 22765
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 07 Dec 2017 19:19:35 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171207/d0cf61ac/attachment.html>


More information about the coreboot-gerrit mailing list