[coreboot-gerrit] Change in coreboot[master]: mainboard/compulab: enable SuperIO UART

Patrick Rudolph (Code Review) gerrit at coreboot.org
Wed Dec 6 07:57:04 CET 2017


Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/22737 )

Change subject: mainboard/compulab: enable SuperIO UART
......................................................................


Patch Set 2:

(2 comments)

https://review.coreboot.org/#/c/22737/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/22737/2//COMMIT_MSG@14
PS2, Line 14: Also changed devicetree to use the correct CPU socket.
Please make that a separate commit, as it's unrelated to UART.


https://review.coreboot.org/#/c/22737/2/src/mainboard/compulab/intense_pc/devicetree.cb
File src/mainboard/compulab/intense_pc/devicetree.cb:

https://review.coreboot.org/#/c/22737/2/src/mainboard/compulab/intense_pc/devicetree.cb@31
PS2, Line 31: 		chip cpu/intel/socket_FCBGA1023
looks unrelated to uart



-- 
To view, visit https://review.coreboot.org/22737
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11a4c532ed73a0cf27d6e7bef6e04035c3942567
Gerrit-Change-Number: 22737
Gerrit-PatchSet: 2
Gerrit-Owner: Hal Martin <hal.martin+coreboot at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 06 Dec 2017 06:57:04 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171206/162ef218/attachment.html>


More information about the coreboot-gerrit mailing list