[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT

[Furquan Shaikh (Code Review)]

Furquan Shaikh has uploaded this change for review. ( https://review.coreboot.org/22690


Change subject: soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT
......................................................................

soc/intel/cannonlake: Fix DSX_CFG macro name for AC_PRESENT

DSX_CFG provides a config option to disable internal pull-down on
AC_PRESENT. This change updates macro name to reflect this correctly.

Change-Id: I620d7da4048178f86de41f3afd98543cf8efc5ce
Signed-off-by: Furquan Shaikh <furquan at chromium.org>
---
M src/soc/intel/cannonlake/chip.h
M src/soc/intel/cannonlake/include/soc/pmc.h
2 files changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/22690/1

diff --git a/src/soc/intel/cannonlake/chip.h b/src/soc/intel/cannonlake/chip.h
index 9d6f594..fd89339 100644
--- a/src/soc/intel/cannonlake/chip.h
+++ b/src/soc/intel/cannonlake/chip.h
@@ -77,7 +77,7 @@
 	/* Deep Sx Configuration
 	 *  DSX_EN_WAKE_PIN       - Enable WAKE# pin
 	 *  DSX_EN_LAN_WAKE_PIN   - Enable LAN_WAKE# pin
-	 *  DSX_EN_AC_PRESENT_PIN - Enable AC_PRESENT pin */
+	 *  DSX_DIS_AC_PRESENT_PD - Disable pull-down on AC_PRESENT pin */
 	uint32_t deep_sx_config;
 
 	/* TCC activation offset */
diff --git a/src/soc/intel/cannonlake/include/soc/pmc.h b/src/soc/intel/cannonlake/include/soc/pmc.h
index fd28859..0276d46 100644
--- a/src/soc/intel/cannonlake/include/soc/pmc.h
+++ b/src/soc/intel/cannonlake/include/soc/pmc.h
@@ -103,7 +103,7 @@
 #define   REQ_CNV_NOWAKE_DSX		(1 << 4)
 #define    REQ_BATLOW_DSX		(1 << 3)
 #define   DSX_EN_WAKE_PIN		(1 << 2)
-#define   DSX_EN_AC_PRESENT_PIN		(1 << 1)
+#define   DSX_DIS_AC_PRESENT_PD	(1 << 1)
 #define   DSX_EN_LAN_WAKE_PIN		(1 << 0)
 #define DSX_CFG_MASK			(0x1f << 0)
 

-- 
To view, visit https://review.coreboot.org/22690
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I620d7da4048178f86de41f3afd98543cf8efc5ce
Gerrit-Change-Number: 22690
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171204/8ee34770/attachment-0001.html>