[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variants/nautilus: Change USB2 phy setting

shkim (Code Review) gerrit at coreboot.org
Mon Dec 4 04:09:47 CET 2017


shkim has uploaded this change for review. ( https://review.coreboot.org/22686


Change subject: mb/google/poppy/variants/nautilus: Change USB2 phy setting
......................................................................

mb/google/poppy/variants/nautilus: Change USB2 phy setting

In order to pass USB2 eye diagram, some USB2 port PHY registers
needs to be changed.

Port1 (Type-A): USB2_PORT_SHORT
Port2 (BT): USB2_PORT_SHORT
Port6 (H1): USB2_PORT_SHORT
Port7 (Camera): USB2_PORT_SHORT

BUG=none
BRANCH=master
TEST=emerge-nautilus coreboot and do eye-diagram test
Signed-off-by: sh.kim <sh_.kim at samsung.com>

Change-Id: I174e5bf96a53bb210481fb88298d5341f6c11dec
---
M src/mainboard/google/poppy/variants/nautilus/devicetree.cb
1 file changed, 9 insertions(+), 9 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/22686/1

diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
index fe11a2e..98b646b 100644
--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
@@ -158,17 +158,17 @@
 	# RP 1 uses SRCCLKREQ1#
 	register "PcieRpClkReqNumber[0]" = "1"
 
-	register "usb2_ports[0]" = "USB2_PORT_LONG(OC0)"	# Type-C Port 1
-	register "usb2_ports[1]" = "USB2_PORT_MID(OC_SKIP)"	# Type-A Port
-	register "usb2_ports[2]" = "USB2_PORT_MID(OC_SKIP)"	# Bluetooth
-	register "usb2_ports[4]" = "USB2_PORT_LONG(OC1)"	# Type-C Port 2
-	register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)"	# Type-A Port
-	register "usb2_ports[8]" = "USB2_PORT_MID(OC_SKIP)"	# Type-A Port
+	register "usb2_ports[0]" = "USB2_PORT_LONG(OC0)"		# Type-C Port 1
+	register "usb2_ports[1]" = "USB2_PORT_SHORT(OC_SKIP)"	# Type-A Port
+	register "usb2_ports[2]" = "USB2_PORT_SHORT(OC_SKIP)"	# Bluetooth
+	register "usb2_ports[4]" = "USB2_PORT_LONG(OC1)"		# Type-C Port 2
+	register "usb2_ports[6]" = "USB2_PORT_SHORT(OC_SKIP)"	# H1
+	register "usb2_ports[8]" = "USB2_PORT_SHORT(OC_SKIP)"	# Camera
 
-	register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC0)"	# Type-C Port 1
-	register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC1)"	# Type-C Port 2
+	register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC0)"		# Type-C Port 1
+	register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC1)"		# Type-C Port 2
 	register "usb3_ports[2]" = "USB3_PORT_DEFAULT(OC_SKIP)"	# Type-A Port
-	register "usb3_ports[3]" = "USB3_PORT_EMPTY"		# Empty
+	register "usb3_ports[3]" = "USB3_PORT_EMPTY"			# Empty
 
 	# Touchscreen
 	register "i2c_voltage[0]" = "I2C_VOLTAGE_3V3"

-- 
To view, visit https://review.coreboot.org/22686
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I174e5bf96a53bb210481fb88298d5341f6c11dec
Gerrit-Change-Number: 22686
Gerrit-PatchSet: 1
Gerrit-Owner: shkim <sh_.kim at samsung.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171204/db5489bb/attachment-0001.html>


More information about the coreboot-gerrit mailing list