[coreboot-gerrit] Change in coreboot[master]: soc/amd/stoneyridge: Add USB OC support
Martin Roth (Code Review)
gerrit at coreboot.org
Sat Dec 2 06:49:21 CET 2017
Martin Roth has posted comments on this change. ( https://review.coreboot.org/22678 )
Change subject: soc/amd/stoneyridge: Add USB OC support
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c
File src/soc/amd/stoneyridge/usb.c:
https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c@30
PS1, Line 30:
nit: Extra newlines here and above
https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c@32
PS1, Line 32: ==
Is there a reason for this spacing?
https://review.coreboot.org/#/c/22678/1/src/soc/amd/stoneyridge/usb.c@36
PS1, Line 36: (uint32_t)
I don't think this cast is needed.
--
To view, visit https://review.coreboot.org/22678
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie54c7a2baa78f21cf1cd30d5ed70c8c832cf3674
Gerrit-Change-Number: 22678
Gerrit-PatchSet: 1
Gerrit-Owner: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sat, 02 Dec 2017 05:49:21 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171202/dcc72c83/attachment.html>
More information about the coreboot-gerrit
mailing list