[coreboot-gerrit] Change in coreboot[master]: security/vboot: Fix bug introduced by CL:22120

Daisuke Nojiri (Code Review) gerrit at coreboot.org
Fri Dec 1 17:35:01 CET 2017


Daisuke Nojiri has uploaded this change for review. ( https://review.coreboot.org/22668


Change subject: security/vboot: Fix bug introduced by CL:22120
......................................................................

security/vboot: Fix bug introduced by CL:22120

CL:22120 inserted printk and kicked out google_chromeec_reboot
from the if-clause. This patch fixes it.

BUG=none
BRANCH=none
TEST=none

Change-Id: I058e929e2acd883d2265b2ab019743e3849cb3af
Signed-off-by: Daisuke Nojiri <dnojiri at chromium.org>
---
M src/vendorcode/google/chromeos/cr50_enable_update.c
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/22668/1

diff --git a/src/vendorcode/google/chromeos/cr50_enable_update.c b/src/vendorcode/google/chromeos/cr50_enable_update.c
index 6e67cc2..7e8806e 100644
--- a/src/vendorcode/google/chromeos/cr50_enable_update.c
+++ b/src/vendorcode/google/chromeos/cr50_enable_update.c
@@ -60,10 +60,11 @@
 	printk(BIOS_INFO, "Waiting for CR50 reset to pick up update.\n");
 
 	if (IS_ENABLED(CONFIG_POWER_OFF_ON_CR50_UPDATE)) {
-		if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC))
+		if (IS_ENABLED(CONFIG_EC_GOOGLE_CHROMEEC)) {
 			printk(BIOS_INFO, "Hibernating EC.\n");
 			google_chromeec_reboot(0, EC_REBOOT_HIBERNATE,
 				EC_REBOOT_FLAG_ON_AP_SHUTDOWN);
+		}
 		poweroff();
 	}
 	halt();

-- 
To view, visit https://review.coreboot.org/22668
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I058e929e2acd883d2265b2ab019743e3849cb3af
Gerrit-Change-Number: 22668
Gerrit-PatchSet: 1
Gerrit-Owner: Daisuke Nojiri <dnojiri at chromium.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171201/c412f3b1/attachment.html>


More information about the coreboot-gerrit mailing list