[coreboot-gerrit] Change in coreboot[master]: mainboard/googke/kahlee: Remove usb_oc.asl files

Martin Roth (Code Review) gerrit at coreboot.org
Fri Dec 1 04:35:04 CET 2017


Martin Roth has uploaded this change for review. ( https://review.coreboot.org/22659


Change subject: mainboard/googke/kahlee: Remove usb_oc.asl files
......................................................................

mainboard/googke/kahlee: Remove usb_oc.asl files

These files aren't needed for the overcurrent functionality.

BUG=b:69305596, b:69229635
TEST=Build Grunt & Kahlee.  Overcurrent wasn't yet enabled so no other
testing was needed.

Change-Id: I8dcd50a249e387ccf1142949b359cee09942460a
Signed-off-by: Martin Roth <martinroth at google.com>
---
M src/mainboard/google/kahlee/dsdt.asl
D src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/usb_oc.asl
D src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/usb_oc.asl
D src/mainboard/google/kahlee/variants/kahlee/include/variant/acpi/usb_oc.asl
4 files changed, 0 insertions(+), 85 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/22659/1

diff --git a/src/mainboard/google/kahlee/dsdt.asl b/src/mainboard/google/kahlee/dsdt.asl
index ded0dc8..ff3bb73 100644
--- a/src/mainboard/google/kahlee/dsdt.asl
+++ b/src/mainboard/google/kahlee/dsdt.asl
@@ -33,9 +33,6 @@
 	/* Globals for the platform */
 	#include "acpi/mainboard.asl"
 
-	/* Describe the USB Overcurrent pins */
-	#include "variant/acpi/usb_oc.asl"
-
 	/* PCI IRQ mapping for the Southbridge */
 	#include <pcie.asl>
 
diff --git a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/usb_oc.asl b/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/usb_oc.asl
deleted file mode 100644
index 72f26d8..0000000
--- a/src/mainboard/google/kahlee/variants/baseboard/include/baseboard/acpi/usb_oc.asl
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2015 Advanced Micro Devices, Inc.
- * Copyright (C) 2013 Sage Electronic Engineering, LLC
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-/* USB overcurrent mapping pins.   */
-Name (UOM0, 0)
-Name (UOM1, 0)
-Name (UOM2, 0)
-Name (UOM3, 0)
-Name (UOM4, 0)
-Name (UOM5, 0)
-Name (UOM6, 0)
-Name (UOM7, 0)
-Name (UOM8, 0)
-Name (UOM9, 0)
-
-/* USB Overcurrent GPEs */
diff --git a/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/usb_oc.asl b/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/usb_oc.asl
deleted file mode 100644
index d22628c..0000000
--- a/src/mainboard/google/kahlee/variants/grunt/include/variant/acpi/usb_oc.asl
+++ /dev/null
@@ -1,16 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright 2017 Google Inc.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#include <baseboard/acpi/usb_oc.asl>
diff --git a/src/mainboard/google/kahlee/variants/kahlee/include/variant/acpi/usb_oc.asl b/src/mainboard/google/kahlee/variants/kahlee/include/variant/acpi/usb_oc.asl
deleted file mode 100644
index 068d6fd..0000000
--- a/src/mainboard/google/kahlee/variants/kahlee/include/variant/acpi/usb_oc.asl
+++ /dev/null
@@ -1,37 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright (C) 2015 Advanced Micro Devices, Inc.
- * Copyright (C) 2013 Sage Electronic Engineering, LLC
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-/* simple name description */
-/*
- * DefinitionBlock ("DSDT.AML","DSDT",0x01,"XXXXXX","XXXXXXXX",0x00010001)
- * {
- *	#include "usb.asl"
- * }
- */
-
-/* USB overcurrent mapping pins.   */
-Name (UOM0, 0)
-Name (UOM1, 2)
-Name (UOM2, 0)
-Name (UOM3, 7)
-Name (UOM4, 2)
-Name (UOM5, 2)
-Name (UOM6, 6)
-Name (UOM7, 2)
-Name (UOM8, 6)
-Name (UOM9, 6)
-
-/* USB Overcurrent GPEs */

-- 
To view, visit https://review.coreboot.org/22659
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8dcd50a249e387ccf1142949b359cee09942460a
Gerrit-Change-Number: 22659
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20171201/a5b4fffd/attachment-0001.html>


More information about the coreboot-gerrit mailing list