[coreboot-gerrit] Change in coreboot[master]: buildgcc: Fix up cross GCC building
Nico Huber (Code Review)
gerrit at coreboot.org
Thu Aug 31 23:18:32 CEST 2017
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/21307
Change subject: buildgcc: Fix up cross GCC building
......................................................................
buildgcc: Fix up cross GCC building
Add a missing line-break escape and, rather cosmetic, guard execution of
$CXX which we allow but don't force to be set.
Change-Id: Icf6d3b7de4b7999b8214489f28997964c490d1e9
Signed-off-by: Nico Huber <nico.h at gmx.de>
---
M util/crossgcc/buildgcc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/21307/1
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index dcfb9a6..07aaf68 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -659,7 +659,7 @@
# Work around crazy code generator in GCC that confuses CLANG.
$CC --version | grep clang >/dev/null 2>&1 && \
CLANGFLAGS="-fbracket-depth=1024"
- $CXX --version | grep clang >/dev/null 2>&1 && \
+ [ -n "$CXX" ] && $CXX --version | grep clang >/dev/null 2>&1 && \
CLANGCXXFLAGS="-fbracket-depth=1024"
# GCC does not honor HOSTCFLAGS at all. CFLAGS are used for
@@ -670,7 +670,7 @@
# Also set the CXX version of the flags because GCC is now compiled
# using C++.
CC="$(hostcc target)" CXX="$(hostcxx target)" \
- CFLAGS_FOR_TARGET="-O2 -Dinhibit_libc"
+ CFLAGS_FOR_TARGET="-O2 -Dinhibit_libc" \
CFLAGS="$HOSTCFLAGS $CLANGFLAGS" \
CFLAGS_FOR_BUILD="$HOSTCFLAGS $CLANGFLAGS" \
CXXFLAGS="$HOSTCFLAGS $CLANGCXXFLAGS" \
--
To view, visit https://review.coreboot.org/21307
To unsubscribe, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf6d3b7de4b7999b8214489f28997964c490d1e9
Gerrit-Change-Number: 21307
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h at gmx.de>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20170831/632283c3/attachment-0001.html>
More information about the coreboot-gerrit
mailing list